Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999
Summary: "Debarred Until" display in the opac tells patrons they are debarred until th...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 14:33 UTC by Liz Rea
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (5.30 KB, patch)
2011-12-08 15:25 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 (5.41 KB, patch)
2011-12-08 15:43 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 7337 - Followup - Correcting instances of "debar" that crept back in. (2.21 KB, patch)
2011-12-08 16:31 UTC, Liz Rea
Details | Diff | Splinter Review
Revised fix (7.86 KB, patch)
2011-12-08 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999 (8.17 KB, patch)
2011-12-08 17:49 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2011-12-08 14:33:52 UTC
When you debar a patron, and then log in to the opac as that patron, the patron is told their account is restricted until the year 9999.

See screenshot:
http://screencast.com/t/QKvVMFzTbi
Comment 1 Owen Leonard 2011-12-08 15:25:43 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2011-12-08 15:43:30 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2011-12-08 16:31:55 UTC
Created attachment 6671 [details] [review]
Bug 7337 - Followup - Correcting instances of "debar" that crept back in.

To test:
Restrict one of your patrons -
Make sure that on memberentrygen.tt (Edit Patron) the radio button label says "Restricted"
Make sure that on moremember.tt (Patron detail) the button to lift debarment says "Restricted"
Comment 4 Liz Rea 2011-12-08 16:32:40 UTC
Comment on attachment 6668 [details] [review]
[Signed Off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999

Found a problem with the template renewing books for debarred patrons. Owen says he'll revise and I'll provide a new signoff.
Comment 5 Owen Leonard 2011-12-08 17:36:50 UTC Comment hidden (obsolete)
Comment 6 Liz Rea 2011-12-08 17:49:26 UTC
Created attachment 6674 [details] [review]
[Signed off] Bug 7337 - "Debarred Until" display in the opac tells patrons they are debarred until the year 9999

This patch copies the debarred handling method from circulation.pl for
use on opac-user.pl so that debarred dates and comments can be handled
properly.

I have slightly reworded the message in the OPAC and on circulation.pl
to make the display of the debarred comment a little clearer.

Revision adds missing handling of debarred status with regard to
renewal operations. Renew links and buttons were not being hidden
from debarred users.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Renewal buttons are gone, message looks good.

liz@koha-deb:~/kohaclone$ prove xt
xt/permissions.t .. ok
xt/tt_valid.t ..... ok
All tests successful.
Files=2, Tests=27,  9 wallclock secs ( 0.05 usr  0.01 sys +  8.28 cusr  0.08 csys =  8.42 CPU)
Result: PASS
Comment 7 Ian Walls 2012-01-05 13:10:27 UTC
Both attached patches are template-level only (with some small bit of additional logic in opac/opac-user.pl to pass the right variables).  Easy to read, and removes the display of system-placeholder dates like 9999-12-31.

Marking Passed QA
Comment 8 Paul Poulain 2012-01-06 14:09:14 UTC
patch pushed, please test
Comment 9 Jared Camins-Esakov 2012-12-31 00:21:28 UTC
There have been no further reports of problems so I am marking this bug resolved.