koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt: 52 <li>Your perl version seems to be obsolete. 53 Please upgrade to a newer version of Perl (at least Version 5.006001).</li> This should say at least version 5.10. How should the version number be formatted? Is a simple "5.10" enough or should it be something like "5.010001"?
perl -v says with me: This is perl, v5.10.0 built for x86_64-linux-thread-multi So I would go for a simple 5.10
Oops, I just assumed that the installer was actually checking for 5.10, but it seems it does not: 62 unless ( $] >= 5.008008 ) { # Bug 4505 63 $template->param( problems => 1, perlversion => 1, checkmodule => 0 ); I have changed the name of this bug to reflect the broader scope of this bug.
Created attachment 6922 [details] [review] Proposed patch - Change the installer script to look for at least 5.10/5.010000 - Change the template to ask for the correct version To test: - Run through the webinstaller on 5.10 or newer and check that there are no errors. - Ideally: Run through the webinstaller on an older version than 5.10 and check that there *is* an error, asking for 5.10 or newer.
Created attachment 6926 [details] [review] Bug 7375 - Update minimum version of Perl to 5.10 - Change the installer script to look for at least 5.10/5.010000 - Change the template to ask for the correct version To test: - Run through the webinstaller on 5.10 or newer and check that there are no errors. - Ideally: Run through the webinstaller on an older version than 5.10 and check that there *is* an error, asking for 5.10 or newer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Simple change to version numbers, one in a comparison, other in a string. Marking Passed QA (as 5.10 is indeed the minimum version at this time)
Patch pushed, please test
Included in the 3.6 branch prior to 3.6.4.
This has been in use for a while, without any complaints.