There is no [+] on patron search from patron detail page like there is on the main patron's page. It should be in all places.
*** Bug 10316 has been marked as a duplicate of this bug. ***
upping severity on this because it causes a lot of confusion in the trainings i'm doing lately
Tested on current master: - Patron module main page - [+] is there and working - Patron detail page - [+] is there, but not working correctly. The additional fields don't show up.
Created attachment 29697 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library
Jonathan, I tried applying this patch to master to test it, and received this message: fatal: sha1 information is lacking or useless (Koha/Template/Plugin/Branches.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7380: Refactor the patron search box header I'm brand new to testing patches with git bz, so it may be my setup, but other patches have applied successfully.
This patch depends on bug 11944.
I tried to apply this on top of biblibre/ft/bug_11944 and still got the same error Heather did. Am I testing this incorrectly?
Created attachment 33157 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library
It applied correctly here but with some "Auto-merging". Could you retry with this new patch please?
Hm not sure what's wrong - I tried applying 11944 first, but got a couple of conficts. 7380 won't apply alone either.
You should use the branch ft/bug_11944, not the patches on the bug report.
Created attachment 35222 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library
Rebase against master (with 11944), small conflict fixed.
Created attachment 35259 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
The library and category filters on moremember.pl appear to be preset to the library and category of the patron you are viewing. This seems improper.
Created attachment 35342 [details] [review] [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. Tested with both patches together. Passwords with leading/trailing whitspaces are rejected as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 35342 [details] [review] [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Sorry for the noise, mistaked wit bug number.
Created attachment 37805 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37806 [details] [review] Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected.
(In reply to Kyle M Hall from comment #15) > The library and category filters on moremember.pl appear to be preset to the > library and category of the patron you are viewing. This seems improper. Thanks for the catch! Should be fixed with the last patch.
Created attachment 38053 [details] [review] Revert "Bug 13189: (QA Followup) Unit Tests" This reverts commit a7822b0a32faa5ffe6e5a3b43c1cd2c58a8a802a. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment on attachment 38053 [details] [review] Revert "Bug 13189: (QA Followup) Unit Tests" Something strange is going on on my system - ignore me
Created attachment 38055 [details] [review] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 38056 [details] [review] Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 38067 [details] [review] [PASSED QA] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 38068 [details] [review] [PASSED QA] Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Functionally I am fie with this, pushing it back to Jonathan asking nicely for some tests!
Created attachment 38090 [details] [review] Bug 7380: Add tests for TT plugins
Created attachment 38107 [details] [review] k
Created attachment 38108 [details] [review] [PASSED QA] Bug 7380: Add tests for TT plugins Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
The new tests pass for me without any problem. They are differently named ot the existing plugin pathces where the directory structure is only reflected in the file name.
Patches pushed to master. Good one Jonathan!
*** Bug 12982 has been marked as a duplicate of this bug. ***