Those square corners were oh-so-harsh. I want to make them rounded so as to be comfortable.
Created attachment 6964 [details] [review] Bug 7388 [enh] - round the corners on the side menus in the staff client To test: apply patch check menus on circulation and bib detail page - corners on the menus to the left should be rounded.
Created attachment 6965 [details] [review] Bug 7388 [enh] - Adding a <div id="menu"> </div> around the acquisitions menu so that it matches the rest of the interface. To test: Click more -> acquisitions verify the menu items are on tabs. This patch doesn't depend upon the last one, but the tabs are prettier when they are rounded. ;)
Created attachment 6966 [details] [review] Bug 7388 [enh] - add menu styling to serials To test: Click more -> serials - please make sure you have at least one subscription! You should see that the menu on the left is now in tabs. Again, this doesn't depend on the initial patch here, but those corners sure do look prettier when they are rounded.
Created attachment 6967 [details] [review] Bug 7388 [enh] - adding menu div to guided reports screen To test: More -> reports -> Guided Reports Wizard Verify that the menu items on the left hand side are in menu tabs. Here again - much prettier when the corners are rounded.
I disagree with the addition of the styling of the acquisitions, serials, and reports menu. The style of the sidebar tabs on patron-related screens and title-related screens is linked to the kind of menu options they present. Those menu options are for different ways you can view one thing: a patron or a bibliographic record. You can view that patron's details, fines, circ history, etc (checkouts is kind of cheating). You can view a title's normal view, marc view, items, etc. This isn't true for acquisitions, for instance, where the menu options are for doing different tasks. I'm not opposed to improving the style of those menus, but I'd prefer to introduce a new standard which doesn't muddy the distinct purpose of the existing "view menus." No objections here to the rounded corners though.
just for the sake of argument - I wonder if people really "get" the distinction you are making. I never thought of those things as "views," I thought of them as "other stuff you can do while in this particular area of Koha." That's probably fundamentally different from how you think about it. I'm willing to concede the last 3 patches based on your judgement, however I'm not sure I *entirely* agree with you - I'm unable to conceive of a better way to deal with those menus - they seem inconsistent to me and the most obvious way to satisfy my own compulsion for consistency was to add the menu styling to them. They don't seem suited to buttons, links don't seem attention-getting enough, the horizontal menus are being used for other functions. I'm at a bit at a loss. Also, for anyone testing, please feel free to go ahead and test/sign off the 1st patch of this series - it's trivial and uncontroversial (or at least I think it should be uncontroversial). ;)
Created attachment 7063 [details] [review] Bug 7388 [SIGNED-OFF] [enh] - round the corners on the side menus in the staff client To test: apply patch check menus on circulation and bib detail page - corners on the menus to the left should be rounded. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Those rounded corners do look more friendly. I have tested circulation and bib detail page and have found no ill side effects.
I have tested and signed off on the first patch, the one called "round the corners on the side menus in the staff client". I'm changing the status to "Signed Off", but if that patch gets pushed the status should be reset to "Needs signoff" for the remaining patches. Or maybe those batches could be moved to one or more separate bugs?
So just to be completely clear: attachment 7063 [details] [review] is the only one I have signed off, pending further discussion of the other patches.
discussion started by owen in comment 5
This is not in discussion - the rounded corners are signed off and ready for QA.
QA comment: tiny patch, nothing to say