Bug 7394 - Broken detail page for last link from result page
Summary: Broken detail page for last link from result page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) critical
Assignee: Chris Cormack
QA Contact: Ian Walls
URL:
Keywords:
Depends on: 6483
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-02 14:01 UTC by Katrin Fischer
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
wrong display on opac detail page (32.86 KB, image/png)
2012-01-02 14:01 UTC, Katrin Fischer 		Details
Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing (2.59 KB, patch)
2012-01-03 06:58 UTC, Chris Cormack 		Details | Diff | Splinter Review
Signed-off patch (2.78 KB, patch)
2012-01-03 07:16 UTC, Frédéric Demians 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing (2.73 KB, patch)
2012-01-03 07:16 UTC, Katrin Fischer 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing (2.94 KB, patch)
2012-01-03 07:20 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-01-02 14:01:58 UTC 
Created attachment 7013 [details]
wrong display on opac detail page

Found a weird bug, where the detail page wrongly uses the result page XSLT.
The title shows formatted as link and availability information is displayed. (see screenshot)

To reproduce:

1) OPACXSLTDetailsDisplay = ON
2) OPACXSLTResultDisplay = ON
3) Search for anything with more than 20 results. 
4) Open the last record (normally 20th) of your the result page.
5) Go to the second reult page, same happens here for the last link (40th)
Comment 1 Chris Cormack 2012-01-03 06:47:44 UTC 
Its the browse results thing that is causing this.

Which reminds me, that whole thing should be wrapped in a system preference, as well as fixed
Comment 2 Chris Cormack 2012-01-03 06:58:57 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2012-01-03 07:00:15 UTC 
Fix for problem, will do 2 follow ups

1 to add a syspref, 1 to shift all the code to a module instead of in the opac-detail.pl

But please signoff and push the fix without waiting on the follow ups
Comment 4 Frédéric Demians 2012-01-03 07:09:34 UTC 
Related to bug 6483.
Comment 5 Frédéric Demians 2012-01-03 07:16:44 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2012-01-03 07:16:58 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2012-01-03 07:20:07 UTC 
Created attachment 7024 [details] [review]
[SIGNED-OFF] Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

I can confirm the bug and the solution.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Second sign-off from me, patch fixes display of detail page
for last record on a result page.
Comment 8 Ian Walls 2012-01-03 18:31:57 UTC 
Moves code to different area of script to avoid scoping issues.  Fixes issue without introducing any new complexities.  Marking as Passed QA
Comment 9 Paul Poulain 2012-01-06 11:34:38 UTC 
patch pushed, pleast test
Comment 10 Chris Nighswonger 2012-01-21 04:37:28 UTC 
This patch does not apply cleanly to 3.4.x. Please rebase and attach a new patch.
Comment 11 Katrin Fischer 2012-01-21 07:47:18 UTC 
The 'browse results' was a new feature in 3.6 and is not in 3.4 (afaik). The problem should not appear there.
Comment 12 Chris Nighswonger 2012-01-21 12:42:24 UTC 
TNX!