Bug 7402 - invoice not showing received titles
Summary: invoice not showing received titles
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.8
Hardware: All All
: P3 normal
Assignee: Chris Cormack
QA Contact: Ian Walls
URL:
Keywords:
Depends on: 929
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-04 19:03 UTC by Nicole C. Engard
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 7402 : Fixing the date formatting so links to the invoice page work (2.27 KB, patch)
2012-01-04 19:57 UTC, Chris Cormack 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7402 : Fixing the date formatting so links to the invoice page work (2.45 KB, patch)
2012-01-18 07:43 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-01-04 19:03:27 UTC 
When you do an order search you can click on the invoice number next to the titles in question.  Clicking that invoice though does not show you the items you received on that order - the 'Already Received' section lists no titles even if you have received titles on that invoice.
Comment 1 Nicole C. Engard 2012-01-04 19:06:09 UTC 
The URL after clicking the invoice number is:

cgi-bin/koha/acqui/parcel.pl?invoice=4567890-9&supplierid=1&datereceived=07/27/2011

The URL that works was:

/cgi-bin/koha/acqui/parcels.pl?supplierid=28
Comment 2 Nicole C. Engard 2012-01-04 19:08:25 UTC 
Sorry, I worded that wrong.  If you click the date on the second URL I gave it shows you items you have received. The URL is:

cgi-bin/koha/acqui/parcel.pl?type=intra&supplierid=1&datereceived=2011-12-15&invoice=323231


So the date format in the broken URL is probably causing problems.
Comment 3 Chris Cormack 2012-01-04 19:28:31 UTC 
Hmm this could be fixed by using the new KohaDates filter which is part of bug 929

Ill get 929 rebased then will fix this.
Comment 4 Chris Cormack 2012-01-04 19:57:12 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2012-01-04 19:57:57 UTC 
This depends on 929, which is passed QA so should be in master soon

But to test before then, need to apply the patches from 929 then this
Comment 6 Katrin Fischer 2012-01-18 07:40:19 UTC 
Hm, it does not work for me. I think the problem is, that the URL needs the date in iso format - not relying on dateformat setttings.

From 929:
my $datereceived = C4::Dates->new( $data->{'datereceived'}, 'iso' );

Working link:
http://localhost:8080/cgi-bin/koha/acqui/parcel.pl?invoice=7402&supplierid=1&datereceived=2012-01-18
Comment 7 Katrin Fischer 2012-01-18 07:41:40 UTC 
Well... it certainly helps to apply the patch you want to test before testing...
patch does just that and works nicely.
Comment 8 Katrin Fischer 2012-01-18 07:43:30 UTC 
Created attachment 7210 [details] [review]
[SIGNED-OFF] Bug 7402 : Fixing the date formatting so links to the invoice page work

This depends on bug 929

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Uses the new TT plugin to display the date, while using iso format
to build a correct URL to the invoice page.
Comment 9 Ian Walls 2012-01-21 17:27:22 UTC 
Moves formatting of dates from perl to template, making use of new Koha Dates filter.  Simple change, marking as Passed QA
Comment 10 Katrin Fischer 2012-03-11 08:10:42 UTC 
Works on master and patch is also in 3.6.x - marking resolved.