When userid is automatically generated from firstname and surname, diacritics should be removed because login with diacritics may results in failure
Created attachment 7064 [details] [review] Bug 7411 : remove diacritics from userid when generated automatically
http://mantis.biblibre.com/view.php?id=7744
I'm wondering why it's using Text::Undiacritic instead of Text::Unaccent which is more popular and already packaged in Debian.
Using a module that is packaged for Debian would be a good idea. If this is changed, please remember to add the package to these files: install_misc/debian.packages debian/control
The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks
I talked to Sophie and will try writing a patch using the module suggested by Dobrica.
Created attachment 10048 [details] [review] Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly.
Created attachment 10049 [details] [review] Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly. Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
QA comment: Tiny patch that adds a dependency, but this dep could be used in other places. also adds packages dependencies
This patch introduces a new dependency to fix a bug that happens rarely, I think it should be for 3.10 only, but chris, you decide
Please add to C4::Installer::PerlDependencies
Created attachment 10735 [details] [review] Bug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm Adds new dependency Text::Unaccent to PerlDependencies.pm Module is used currently to remove diacricits from automatically created userid (<first name>.<surname>) in the patron module.
Created attachment 10800 [details] [review] Bug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm Adds new dependency Text::Unaccent to PerlDependencies.pm Module is used currently to remove diacricits from automatically created userid (<first name>.<surname>) in the patron module. Test scenario: 1. open About Koha > Perl modules 2. verify that Text::Unaccent is there Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Last patch marked as Passed QA
Follow-up pushed (on master branch, does not apply anymore on new/bug_7411)
Released in 3.10.0