I think very few libraries in Norway charge anything for lending materials, so having lots of rentalcharges in the sample data makes litle sense.
Hi Magnuse, I think the same applies to German libraries and the rental charge is a bit annoying when working with the sample data. Could you perhaps remove it from the German files too?
Created attachment 8640 [details] [review] Bug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE Set the rentalcharge = 0 for sample itemtypes (except Music for nb-NO). To test: Run through the web-installer for nb-NO and de-DE, and check that itemtypes are displayed correctly for each language.
Created attachment 8659 [details] [review] [SIGNED-OFF] Bug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE Set the rentalcharge = 0 for sample itemtypes (except Music for nb-NO). To test: Run through the web-installer for nb-NO and de-DE, and check that itemtypes are displayed correctly for each language. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>. Note: You have to install the language first in order to be able to select it in the web installer. There was a problem in the po files for nb-NO that kept all files from being created correctly. I fixed the po file and did an installation with all sample files. There is a problem with z3950servers.sql that is not caused by this patch: z3950servers.sql ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1 Web installer for de-DE ran without problems on the sample files.
Katrin asked me to change the status on this one.
Change to default installer values only, not to any existing data. Safe and sound, matches standard behaviour for the nationalities affected, marking as Passed QA
patch pushed, but as you were on this file you could also have updated the insert to have the full version INSERT INTO itemtypes (col1,col2) VALUES (val1,val2); * column names * removed `
This bug will be included in the Koha 3.6.5 release.