When creating a new basketgroup, the billingplace isn't saved. Because of that, the selected branch's informations aren't added to the pdf when printing the basketgroup. If the basket if modified and saved again, the billingplace then gets saved correctly. The problem seems to be around lines 463-472 of acqui/basketgroup.pl and in the NewBasketgroup subroutine : $billingplace isn't saved there.
Created attachment 15608 [details] [review] Proposed patch See commit message
I changed bug name because freedeliveryplace is also concerned.
Patch changes in C4/Acquisition.pm NewBasketgroup() so that it looks more like ModBasketgroup() witch is correct.
Created attachment 15996 [details] [review] Attachment to Bug 7449 - billingplace and freedeliveryplace not saved when creating a new basketgroup Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup billingplace and freedeliveryplace are missing in C4::Acquisition::NewBasketgroup. Test plan : - Go to a vendor basket groups - Create a new basket group - Enter a name - Choose a billing place - Do not choose a delivery place in combobox but enter a text in delivery place textarea - Enter a comment - Save - Edit created basket group => Check that billing place and free delivery place are ok Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
It works, I sign off. M. Saby
Hi Fridolyn, this is certainly an improvement, but I think there is still a little problem with the setting for delivery place: 1) Created a new basket group, set delivery place to "-" 2) Added a delivery address in the text box. 3) Saved. 4) Edited basket group - delivery place is set to my current branch instead of "-" Could you take a look please?
Hello We consider it is a very strange behavior. When creating a basketgroup from a basket, billing and deliveryplace should be the same. But I think this was the behavior for deliveryplace before Fridolyn's patch. So maybe it can be changed in other patch? Mathieu
Hm, I am not sure. But wouldn't it be possible that delivery could go to one branch while bills are handled centrally at the main library? The package would still have a list of delivered items I guess.
So let's say the current behavior is correct -) Before changing it, we may ask the lists, and maybe made a syspref if there are different opinions on that question... Mathieu
Hm, not sure I understand :) What would the syspref change?
Also, shouldn't the bug that you can't save the information correctly be fixed?
I was thinking of a syspref for Using either the librairian's connecting site, or the site used in basket. But maybe not a good idea. What is sure, is that 7449 is already an improvement. For my colleagues it will change life! (currently we have to reopen each basketgroup to change the billingplace...) M. Saby
(In reply to comment #6) > Hi Fridolyn, > > this is certainly an improvement, but I think there is still a little > problem with the setting for delivery place: > > 1) Created a new basket group, set delivery place to "-" > 2) Added a delivery address in the text box. > 3) Saved. > 4) Edited basket group - delivery place is set to my current branch instead > of "-" > > Could you take a look please? This is another problem : Creating a new basketgroup and editing one uses the same page and operation : acqui/basketgroup.pl?op=add&booksellerid=x&basketgroupid=x So when you edit an existing basketgroup, selected branches are librarian branch. Can you create a new bug ? This patch does not change any behavior, it is only a correction in SQL query building.
Hi Fridolyn, I agree this can go on a separate bug. Taking another look now.
Created attachment 17230 [details] [review] [PASSED QA] Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup billingplace and freedeliveryplace are missing in C4::Acquisition::NewBasketgroup. Test plan : - Go to a vendor basket groups - Create a new basket group - Enter a name - Choose a billing place - Do not choose a delivery place in combobox but enter a text in delivery place textarea - Enter a comment - Save - Edit created basket group => Check that billing place and free delivery place are ok Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works according to test plan, delivery place is now correctly saved into the databas and was before lost. All tests and QA script pass.
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.5