basket.pl throws lots of warns, we should fix it. [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $line{"left_holds"} in numeric eq (==) at /home/katrin/kohaclone/acqui/basket.pl line 285., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_rrp_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl [Sun Jan 22 15:47:25 2012] [error] [client 127.0.0.1] [Sun Jan 22 15:47:25 2012] basket.pl: Use of uninitialized value $gist_rrp in sprintf at /home/katrin/kohaclone/acqui/basket.pl line 352., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl
Created attachment 7399 [details] [review] proposed patch
Created attachment 7493 [details] [review] [SIGNED-OFF] Bug 7457: log cleaning on basket.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I confirmed that basket.pl was leaving errors in the log. After the patch I tried opening, modifying, and closing a basket and saw no errors.
Sets default values of zero to various fields (rather than leaving them undefined). Easy change, simple to read, marking Passed QA
This fix was included in the 3.6.x branch prior to 3.6.4.