Bug 7461 - cart offering to remove items when closing
Summary: cart offering to remove items when closing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 03:40 UTC by Nicole C. Engard
Modified: 2013-12-05 19:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (2.43 KB, patch)
2012-01-24 14:16 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing (2.46 KB, patch)
2012-01-24 14:29 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-01-24 03:40:40 UTC
If you have items selected in your cart and you choose to hide the window it asks if you're sure you want to remove items from cart - even though I didn't click the option to remove things from my cart.
Comment 1 Owen Leonard 2012-01-24 14:16:07 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-01-24 14:29:29 UTC
Created attachment 7316 [details] [review]
[SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing

The "hide window" button in the cart called a quit() function
which deletes any checked items. My understanding of the "hide
window" button is that it should *only* hide the window, not
perform any other operations. I'm removing the calls to the
quit() function in both the OPAC and staff client and adding
a CSS class, "close," which is already tied via jQuery to
the window.close() function.

To test in both OPAC and staff client: Add items to the cart.
Try clicking the "hide window" button with items selected and
without. In both cases the window should close without affecting
the contents of the cart.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Marcel de Rooy 2012-02-03 12:26:39 UTC
QA Comment: Works as advertised. Agree that it is unexpected that Hide asks for confirmation for deleting selected items from cart.
Well documented small change. Tiny side-note: it seems that the function quit in the javascript now is obsolete. Could it be removed (follow-up)?
Marking as Passed QA.
Comment 4 Jared Camins-Esakov 2012-05-23 12:58:51 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.