If you have items selected in your cart and you choose to hide the window it asks if you're sure you want to remove items from cart - even though I didn't click the option to remove things from my cart.
Created attachment 7314 [details] [review] Proposed fix The "hide window" button in the cart called a quit() function which deletes any checked items. My understanding of the "hide window" button is that it should *only* hide the window, not perform any other operations. I'm removing the calls to the quit() function in both the OPAC and staff client and adding a CSS class, "close," which is already tied via jQuery to the window.close() function. To test in both OPAC and staff client: Add items to the cart. Try clicking the "hide window" button with items selected and without. In both cases the window should close without affecting the contents of the cart.
Created attachment 7316 [details] [review] [SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing The "hide window" button in the cart called a quit() function which deletes any checked items. My understanding of the "hide window" button is that it should *only* hide the window, not perform any other operations. I'm removing the calls to the quit() function in both the OPAC and staff client and adding a CSS class, "close," which is already tied via jQuery to the window.close() function. To test in both OPAC and staff client: Add items to the cart. Try clicking the "hide window" button with items selected and without. In both cases the window should close without affecting the contents of the cart. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA Comment: Works as advertised. Agree that it is unexpected that Hide asks for confirmation for deleting selected items from cart. Well documented small change. Tiny side-note: it seems that the function quit in the javascript now is obsolete. Could it be removed (follow-up)? Marking as Passed QA.
This fix was included in the 3.6.x branch prior to 3.6.4.