When you duplicate a patron record the duplicate has the patron flags showing. The patron flags should only show when editing a patron not when adding a new patron.
Created attachment 29753 [details] [review] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected.
Created attachment 30154 [details] [review] [SIGNED-OFF] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, all three points confirmed No koha-qa errors
Created attachment 30162 [details] [review] [PASSED QA] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, all three points confirmed No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small template change.
Patch pushed to master. Thanks Owen!
Pushed to 3.16.x for inclusion in 3.16.3.