Bug 7462 - duplicate patron shows flags
Summary: duplicate patron shows flags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 03:41 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7462 - duplicate patron shows flags (1.42 KB, patch)
2014-07-16 13:18 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7462 - duplicate patron shows flags (1.52 KB, patch)
2014-07-26 23:19 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 7462 - duplicate patron shows flags (1.62 KB, patch)
2014-07-27 21:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-01-24 03:41:51 UTC
When you duplicate a patron record the duplicate has the patron flags showing.  The patron flags should only show when editing a patron not when adding a new patron.
Comment 1 Owen Leonard 2014-07-16 13:18:08 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-26 23:19:42 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-27 21:38:04 UTC
Created attachment 30162 [details] [review]
[PASSED QA] Bug 7462 - duplicate patron shows flags

When duplicating a patron the form fields for setting patron account
flags and restrictions should be hidden as it is when adding a patron.
This patch adds the correct logic to the template.

To test, duplicate an existing patron:

- Confirm that the "Patron account flags" and "Patron restrictions"
  sections are not visible.
- Confirm that saving a duplicated patron works correctly.
- Confirm that the edit and new patron entry forms are unaffected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works ok, all three points confirmed
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, small template change.
Comment 4 Tomás Cohen Arazi 2014-07-30 17:26:07 UTC
Patch pushed to master.

Thanks Owen!
Comment 5 Galen Charlton 2014-08-26 22:44:24 UTC
Pushed to 3.16.x for inclusion in 3.16.3.