When a user creates a new vendor, a new borrower or a new basket (maybe on others pages too, to be listed), a creation form is displayed, but the focus is still on the search textbox on page top. It would be probably better to switch the focus to the first field of the creation form.
Created attachment 20128 [details] [review] Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) See commit message. This patch only modifies Acquisition module. For other modules, the search toolbar is mostly on check-out to allow the direct use of a barcode scanner. So modifying the focus may be discussed.
Created attachment 20260 [details] [Signed off] Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) I tested these pages and noticed that the focus had shifted from the search box at the top of the screen to the first field on the screen: - acqui/basketgroup.pl : focus on "Basket group name:" - acqui/basketheader.pl : focus on "Basket name:" - acqui/invoices.tt : focus on "Invoice no:" - acqui/modordernotes.pl : focus on "Notes:" - acqui/neworderempty.pl : focus on "Title:" - acqui/supplier.pl : focus on "Name:" - acqui/z3950_search.pl : focus on "Title:" The only one that I'm not sure about is acqui/neworderempty.pl. I'm not sure if I am looking at the correct screen for testing, but I am on this page and the focus is still on the Vendor Search box at the top of the screen: http://staff-melia.test.bywatersolutions.com/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=2&booksellerid=1&basketno=2 Since all of the others listed here worked for me, I am signing off. Could someone else please test acqui/neworderempty to be sure, and if a problem is found, could that one be addressed in a follow up?
Created attachment 20400 [details] [review] Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) When a user creates a new vendor, a new borrower or a new basket (maybe on others pages too, to be listed), a creation form is displayed, but the focus is still on the search textbox on page top. It would be probably better to switch the focus to the first field of the creation form. This patch adds the focus, for acquisition module, on first input for pages with a data creation or modification or pages with only one form (like Z3950 search). Test plan : Go to pages and look where is the focus : - acqui/basketgroup.pl : focus on "Basket group name:" - acqui/basketheader.pl : focus on "Basket name:" - acqui/invoices.tt : focus on "Invoice no:" - acqui/modordernotes.pl : focus on "Notes:" - acqui/neworderempty.pl : focus on "Title:" - acqui/supplier.pl : focus on "Name:" - acqui/z3950_search.pl : focus on "Title:" Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Created attachment 21078 [details] [review] Bug 7469 - Focus on 1st field of creation form instead of search textbox (Acquisition) When a user creates a new vendor, a new borrower or a new basket (maybe on others pages too, to be listed), a creation form is displayed, but the focus is still on the search textbox on page top. It would be probably better to switch the focus to the first field of the creation form. This patch adds the focus, for acquisition module, on first input for pages with a data creation or modification or pages with only one form (like Z3950 search). Test plan : Go to pages and look where is the focus : - acqui/basketgroup.pl : focus on "Basket group name:" - acqui/basketheader.pl : focus on "Basket name:" - acqui/invoices.tt : focus on "Invoice no:" - acqui/modordernotes.pl : focus on "Notes:" - acqui/neworderempty.pl : focus on "Title:" - acqui/supplier.pl : focus on "Name:" - acqui/z3950_search.pl : focus on "Title:" Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The focus choice is relevant and works as described.
Pushed to master, along with the follow-up that sets the focus for the acqui/parcels.pl form. Thanks, Fridolyn!