7476 – Files executable that probably should not be

Bug 7476 - Files executable that probably should not be

Summary: Files executable that probably should not be

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P3 normal
Assignee:	Aleksa Vujicic
QA Contact:	Marcel de Rooy

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-01-30 20:59 UTC by MJ Ray (software.coop)
Modified:	2013-12-05 20:05 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	Seeking cosponsors
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
xt/find-misplaced-executables (1.33 KB, text/plain) 2012-01-30 20:59 UTC, MJ Ray (software.coop)	Details
Bug 7476 – Remove executable bit from files that probably should not be executed (5.14 KB, patch) 2012-01-30 21:07 UTC, MJ Ray (software.coop)	Details \| Diff \| Splinter Review
[SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed (5.21 KB, patch) 2012-01-31 03:19 UTC, Aleksa Vujicic	Details \| Diff \| Splinter Review
[PASSED_QA] Patch (5.03 KB, patch) 2012-02-03 12:44 UTC, Marcel de Rooy	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description MJ Ray (software.coop) 2012-01-30 20:59:53 UTC Comment hidden (obsolete)

Created attachment 7390 [details]
xt/find-misplaced-executables

The following files are executable and I think they do not need to be.

Please find attached an xt test that lists such misplaced executables.

./acqui/pdfformat/layout2pages.pm
./acqui/pdfformat/layout3pages.pm
./etc/zebradb/marc_defs/marc21/biblios/record.abs
./koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl
./koha-tmpl/opac-tmpl/prog/en/css/opac.css
./koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
./koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
./koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
./installer/data/mysql/sysprefs.sql
./installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql
./installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql
./C4/Auth.pm
./C4/ImportExportFramework.pm
./C4/TTParser.pm
./C4/XSLT.pm

Comment 1 MJ Ray (software.coop) 2012-01-30 21:07:40 UTC Comment hidden (obsolete)

Created attachment 7391 [details] [review]
Bug 7476 – Remove executable bit from files that probably should not be executed

Comment 2 Aleksa Vujicic 2012-01-31 03:19:24 UTC Comment hidden (obsolete)

Created attachment 7396 [details] [review]
[SIGNED-OFF] 7391: Bug 7476 – Remove executable bit from files that probably should not be executed

Comment 3 Marcel de Rooy 2012-02-03 12:44:11 UTC

Created attachment 7442 [details] [review]
[PASSED_QA] Patch

Comment 4 Marcel de Rooy 2012-02-03 12:45:11 UTC

Tested. Works as advertised. Amended patch to correct copy-and-paste comments.
Incrementing status..

Comment 5 Paul Poulain 2012-02-03 13:28:54 UTC

patch pushed, but my suggestion would be to also add
        '!' -name '*.*~' \
and 
        '!' -name '*.old' \
        '!' -name '*.bak' \

to the list of excluded files for xt/find-misplaced-executables

Do you think it could be a good idea ?

Comment 6 Jared Camins-Esakov 2012-12-31 00:34:18 UTC

There have been no further reports of problems so I am marking this bug resolved.