Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT
: Implement DisplayOPACiconsXSLT for NORMARC XSLT
Status: RESOLVED FIXED
Product: Koha
Classification: Unclassified
Component: OPAC
: 3.6
: All All
: P5 - low normal
Assigned To: Magnus Enger
: Jonathan Druart
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-01 17:58 UTC by Magnus Enger
Modified: 2012-04-27 14:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---


Attachments
Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT (1.97 KB, patch)
2012-02-03 08:15 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT (3.50 KB, patch)
2012-02-03 08:57 UTC, Magnus Enger
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT (3.66 KB, patch)
2012-02-12 20:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2012-02-01 17:58:13 UTC
DisplayOPACiconsXSLT has no effect on the display when marcflavour = NORMARC. It should!
Comment 1 Magnus Enger 2012-02-03 08:15:13 UTC
Created attachment 7432 [details] [review]
Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT

This patch actually hides the whole line that contains the icon, including
"literary form" and "audience", but this is how the syspref works for MARC21
too, so I'm sticking with that.

To test:
- Set marcflavour = NORMARC
- Set OPACXSLTResultsDisplay = on
- Set DisplayOPACiconsXSLT = show
- Check that icons and information about "Type", "Litterær form" and
  "Målgruppe" are displayed
- Set DisplayOPACiconsXSLT = don't show
- Check that icons and information is not displayed
Comment 2 Magnus Enger 2012-02-03 08:38:19 UTC
Comment on attachment 7432 [details] [review]
Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT

Oops, forgot to apply this to the detail XSLT. New patch coming...
Comment 3 Magnus Enger 2012-02-03 08:57:59 UTC
Created attachment 7433 [details] [review]
Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT

This patch actually hides the whole line that contains the icon in the result
list, including "literary form" and "audience", but this is how the syspref
works for MARC21 too, so I'm sticking with that.

To test:
- Set marcflavour = NORMARC
- Set OPACXSLTResultsDisplay = on
- Set DisplayOPACiconsXSLT = show
- Check that icons and information about "Type", "Litterær form" and
  "Målgruppe" are displayed in results, "Type" and the icon in detail
- Set DisplayOPACiconsXSLT = don't show
- Check that icons and information is not displayed in result or detail
Comment 4 Katrin Fischer 2012-02-12 20:35:46 UTC
Created attachment 7597 [details] [review]
[SIGNED-OFF] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT

This patch actually hides the whole line that contains the icon in the result
list, including "literary form" and "audience", but this is how the syspref
works for MARC21 too, so I'm sticking with that.

To test:
- Set marcflavour = NORMARC
- Set OPACXSLTResultsDisplay = on
- Set DisplayOPACiconsXSLT = show
- Check that icons and information about "Type", "Litterær form" and
  "Målgruppe" are displayed in results, "Type" and the icon in detail
- Set DisplayOPACiconsXSLT = don't show
- Check that icons and information is not displayed in result or detail

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan worked nicely. Patch works as advertised.
Comment 5 Jonathan Druart 2012-02-15 15:39:31 UTC
Passed QA. Simple Modification in 2 NORMARC xsl files.
It works as expected.
Comment 6 Paul Poulain 2012-02-17 08:56:01 UTC
couldn't check everything is OK, but if it's not, will affect only NORMARC setup, complain against Magnus ;-)
Comment 7 Magnus Enger 2012-04-27 14:33:08 UTC
Works in 3.8.