DisplayOPACiconsXSLT has no effect on the display when marcflavour = NORMARC. It should!
Created attachment 7432 [details] [review] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT This patch actually hides the whole line that contains the icon, including "literary form" and "audience", but this is how the syspref works for MARC21 too, so I'm sticking with that. To test: - Set marcflavour = NORMARC - Set OPACXSLTResultsDisplay = on - Set DisplayOPACiconsXSLT = show - Check that icons and information about "Type", "Litterær form" and "Målgruppe" are displayed - Set DisplayOPACiconsXSLT = don't show - Check that icons and information is not displayed
Comment on attachment 7432 [details] [review] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT Oops, forgot to apply this to the detail XSLT. New patch coming...
Created attachment 7433 [details] [review] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT This patch actually hides the whole line that contains the icon in the result list, including "literary form" and "audience", but this is how the syspref works for MARC21 too, so I'm sticking with that. To test: - Set marcflavour = NORMARC - Set OPACXSLTResultsDisplay = on - Set DisplayOPACiconsXSLT = show - Check that icons and information about "Type", "Litterær form" and "Målgruppe" are displayed in results, "Type" and the icon in detail - Set DisplayOPACiconsXSLT = don't show - Check that icons and information is not displayed in result or detail
Created attachment 7597 [details] [review] [SIGNED-OFF] Bug 7489 - Implement DisplayOPACiconsXSLT for NORMARC XSLT This patch actually hides the whole line that contains the icon in the result list, including "literary form" and "audience", but this is how the syspref works for MARC21 too, so I'm sticking with that. To test: - Set marcflavour = NORMARC - Set OPACXSLTResultsDisplay = on - Set DisplayOPACiconsXSLT = show - Check that icons and information about "Type", "Litterær form" and "Målgruppe" are displayed in results, "Type" and the icon in detail - Set DisplayOPACiconsXSLT = don't show - Check that icons and information is not displayed in result or detail Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan worked nicely. Patch works as advertised.
Passed QA. Simple Modification in 2 NORMARC xsl files. It works as expected.
couldn't check everything is OK, but if it's not, will affect only NORMARC setup, complain against Magnus ;-)
Works in 3.8.