Bug 7517 - Patron category types not appearing as an <optgroup> when editing or creating a patron.
Summary: Patron category types not appearing as an <optgroup> when editing or creating...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Garry Collum
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 21:18 UTC by Garry Collum
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (3.49 KB, patch)
2012-02-09 21:34 UTC, Garry Collum
Details | Diff | Splinter Review
Drop-down prior to patch (16.23 KB, image/jpeg)
2012-02-09 21:35 UTC, Garry Collum
Details
Drop-down after patch (26.38 KB, image/jpeg)
2012-02-09 21:36 UTC, Garry Collum
Details
Signed-off patch (3.71 KB, patch)
2012-02-10 08:09 UTC, Frédéric Demians
Details | Diff | Splinter Review
Revised patch (4.33 KB, patch)
2012-02-25 20:23 UTC, Garry Collum
Details | Diff | Splinter Review
Signed off revised patch (4.35 KB, patch)
2012-03-02 15:49 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Garry Collum 2012-02-09 21:18:02 UTC
At one time the drop-down for borrower categories in the new patron would appear as an <optgroup>.  For example, you would have 'Child' and then your child category types, 'Adult' and then adult types, etc.  These are no longer displaying.
Comment 1 Garry Collum 2012-02-09 21:34:47 UTC Comment hidden (obsolete)
Comment 2 Garry Collum 2012-02-09 21:35:20 UTC
Created attachment 7545 [details]
Drop-down prior to patch
Comment 3 Garry Collum 2012-02-09 21:36:11 UTC
Created attachment 7546 [details]
Drop-down after patch
Comment 4 Frédéric Demians 2012-02-10 08:09:06 UTC Comment hidden (obsolete)
Comment 5 Ian Walls 2012-02-16 16:09:29 UTC
Template only change, most XHTML clean up and TT scope shift.  Marking a Passed QA.
Comment 6 Paul Poulain 2012-02-17 10:45:29 UTC
QA comment

This patch also does 2 un-announced changes:

-<input type="text" name="datedebarred" id="debarred" class="debarred" value="[% datedebarred %]" />
+<input type="text" name="datedebarred" id="datedebarred" class="debarred" value="[% datedebarred %]" />
and
-<textarea id="debarredcomment" name="debarredcomment" cols="55" rows="3" ">[% debarredcomment %]</textarea> 
+<textarea id="debarredcomment" name="debarredcomment" cols="55" rows="3">[% debarredcomment %]</textarea> 

While the 2nd one fixes a HTML mistake (trailing single " at the end of <textarea> I don't understand what the 1st is made for, and I think it should not be here.

and if it should, a few line below, we should also have 
-<input type="text" name="datedebarred" id="debarred" class="debarred" value="[% datedebarred %]" onclick="this.value=''" />
+<input type="text" name="datedebarred" id="datedebarred" class="debarred" value="[% datedebarred %]" onclick="this.value=''" />
Comment 7 Garry Collum 2012-02-25 20:23:32 UTC Comment hidden (obsolete)
Comment 8 Julian Maurice 2012-03-02 15:49:32 UTC
Created attachment 7990 [details] [review]
Signed off revised patch

The new patch still fix the initial problem and fix what has been pointed by Paul.
Signed-off.
Comment 9 Ian Walls 2012-03-05 18:48:57 UTC
Template only change, easy to read, marking as Passed QA.