Options for routing lists and editing routing lists should only show up, when system preference RoutingSerials is ON and user has correct permissions.
Created attachment 7755 [details] [review] Bug 7523: Improve checks for routing permissions - system preference RoutingSerials and user permission routing should be taken into account - print routing list should be independent from routing permission To test, compare to master and check: 1) If system preference RoutingSerials is OFF, routing list functionality is not visible in the templates. 2) If system preference RoutingSerials is ON, but user doesn't have routing permission, routing list functionality is not visible in templates, with exception of 'print list' on the serial collection page. 3) If system preference RoutingSerials is ON and user has routing permissions, all routing links are visible (serial collection, serials navigation, result list of serial search) Additional changes: Changed labels on templates to match HTML4 rule from coding guidelines. http://wiki.koha-community.org/wiki/Coding_Guidelines#Upper_and_Lower_cases_in_strings
Created attachment 7818 [details] [review] [Signed off] Bug 7523: Improve checks for routing permissions - RoutingSerials is OFF: all links to routing list are removed - RoutingSerials is ON and user does not have 'routing' permission: all links to routing list are removed except for 'Print list' in serials-collection.pl - RoutingSerials is ON and user have 'routing' permission: all links to routing list are shown Signed off
QA comment: cosmetic changes only: fixing HTML4 coding guideline rule, some PERL6 -tab instead of 4 spaces- and better permission handling passed QA
lot of string changes, I think it's worth waiting for 3.8, but chris_n, it's up to you