When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower.
Created attachment 7565 [details] [review] Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit enables the mark_returned flag for the LostItem function as it is called from longoverdue.pl
The current functionality is the way we've always expected it to work! Maybe longoverdue.pl needs an option added to it in order to trigger the the process you want?
(In reply to comment #2) Agreed, if this was expected functionality, I will modify my patch and make it a system preference defaulting to the original functionality. Any suggestions for a preference name? RemoveLostItemsFromPatronAccount? > The current functionality is the way we've always expected it to work! Maybe > longoverdue.pl needs an option added to it in order to trigger the the process > you want?
longoverdue.pl is always called from the command line isn't it? So wouldn't a command line parameter be sufficient?
(In reply to comment #4) Good point, I'll make it a command line switch instead. > longoverdue.pl is always called from the command line isn't it? So wouldn't a > command line parameter be sufficient?
Created attachment 7569 [details] [review] Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit adds the command line parameter --mark-returned. If used, longoverdue.pl will remove lost items from the borrowers record. Functionality will remain the same if it is not used.
Created attachment 7570 [details] [review] Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron Added command line switch so original functionality is maintained.
Created attachment 8244 [details] [review] [SIGNED-OFF] Bug 7526 - longoverdue.pl leaves items marked as lost as still checked out to patron When the longoverdu.pl script is run, and it marks an item as lost ( using LostItem() ), if fails to remove the item from the borrower record. So, the item is marked as lost, but is also still listed as checked out to the borrower. This commit adds the command line parameter --mark-returned. If used, longoverdue.pl will remove lost items from the borrowers record. Functionality will remain the same if it is not used. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=7426
Cleanly adds new commandline param to longoverdue.pl to make use of the new functionality. Won't regress any behaviour for libraries who are used to the current way of things. Cleans up some spacing in the GetOpt area. Marking as Passed QA.
There have been no further reports of problems so I am marking this bug resolved.