Bug 7530 - Missing <li> tag in circ-menu.inc
Summary: Missing <li> tag in circ-menu.inc
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low minor (vote)
Assignee: Garry Collum
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-11 17:37 UTC by Garry Collum
Modified: 2013-12-05 19:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.06 KB, patch)
2012-02-11 17:47 UTC, Garry Collum
Details | Diff | Splinter Review
[Signed Off] Bug 7530: Missing <li> tag in circ-menu.inc (1.15 KB, patch)
2012-02-14 19:22 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Garry Collum 2012-02-11 17:37:02 UTC
The address fields of the patron information display of circ-menu.inc is not within <li> tags creating invalid XHTML on several pages.
Comment 1 Garry Collum 2012-02-11 17:47:07 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2012-02-14 19:22:31 UTC
Created attachment 7645 [details] [review]
[Signed Off] Bug 7530: Missing <li> tag in circ-menu.inc

The address information of circ-menu.inc is not contained in <li> tags, this patch fixes it.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
verified new <li> in template. Looks good.
Comment 3 Ian Walls 2012-02-16 16:07:40 UTC
Adds missing start element to list.  This seems to have already been fixed in the .tt version of this file, so marking this simple template change as Passed QA.
Comment 4 Paul Poulain 2012-02-17 09:12:09 UTC
This patch add only a <li>, the </li> was already here, so the HTML is now more valid than before the patch
Comment 5 Jared Camins-Esakov 2012-05-23 13:02:12 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.