Bareword "C4::Search::enabled_staff_search_views" not allowed while "strict subs" in use at /home/wizzyrea/kohaclone/serials/subscription-detail.pl line 146. Execution of /home/wizzyrea/kohaclone/serials/subscription-detail.pl aborted due to compilation errors.
Created attachment 7665 [details] [review] Bug 7546 - cannot view subscription detail This patch adds back a C4::Search removed from auth.pm during the denesting effort.
i should say it adds it where it was missing, in subscription-detail.pl.
Created attachment 7666 [details] [review] Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort.
Problem also serials-edit.pl. adding use C4::Search also adds a compile time error as the routine is not exported. Part of the problem is that the routine is called as a bareword lets call it properly. patch for both to follow
Created attachment 7677 [details] [review] Proposed Patch Fixes the compilation errors in the two scripts. Clarifies the return of the subroutine
Created attachment 7697 [details] [review] Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 7698 [details] [review] bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * cataloguing/additem.pl was missing use C4::Search * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem * why this problem appears now is unclear to me. I understand it's related to de-nesting, but would be happy to have a complete explanation !
Created attachment 7699 [details] [review] Bug 7546 Do not call routine as bareword Fixes compilation errors due to calling routine without parens Also nothing was gained (and obfuscation added) by forcing the return into a hash ref have changed variable to hash tidied up the if else chain These routines should be refactored out future Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
The 2 first patches are signed-off & you can consider them as QAed as they are tiny. Please sign-off mine (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7698&action=diff) , that fixes some remaining problems i've found, and i'll push everything quickly !
Created attachment 7701 [details] [review] bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem
Just seen & pushed the 7545, that solves the additem problem. I also understood why the problem has appeared (see bug 7545 : removing use C4::Search in C4::Heading was the cause)
This patch caused some failed tests in serials (but it may be my data? will double check that): # Failed test 'test getting last or missing issues' # at t/db_dependent/Serials.t line 86. # got: '2' # expected: '0' # Failed test 'test getting late issues' # at t/db_dependent/Serials.t line 44. # got: '2' # expected: '0'
(In reply to comment #12) > This patch caused some failed tests in serials (but it may be my data? will > double check that): it's probably the case, because they are really not related to this part of Koha.
Created attachment 7703 [details] [review] [Signed Off] Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 7546 Do not call routine as bareword Fixes compilation errors due to calling routine without parens Also nothing was gained (and obfuscation added) by forcing the return into a hash ref have changed variable to hash tidied up the if else chain These routines should be refactored out future Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem Signed-off-by: Liz Rea <wizzyrea@gmail.com> Final sign off for all 3 patches Note: I had some problems with tests, but it is probably related to my data and not this patch.
Considering that this patch is a follow-up for bug 6875, i've pushed it in branch new/bug_6875