Bug 7548 - Missing arguments in the pagination of receptions
Summary: Missing arguments in the pagination of receptions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-15 21:52 UTC by Maxime Pelletier
Modified: 2013-12-05 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Fix variable scope in the tt (1.50 KB, patch)
2012-02-15 21:57 UTC, Maxime Pelletier
Details | Diff | Splinter Review
New version of the initial patch - corrected for new master (1.50 KB, patch)
2012-02-29 22:08 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
3.6.x patch (1.78 KB, patch)
2012-06-10 09:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 7548: Missing arguments when receiving orders (1.84 KB, patch)
2012-06-10 13:08 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Pelletier 2012-02-15 21:52:30 UTC
In acquisitions, receive shipment and then enter a vendor invoice and click next. If you have more than 20 pending orders (you can change $resultsperpage = 20 unless ($resultsperpage); in the code to test) there will be a pagination at the bottom. The numbers don't have invoice and datereceived as arguments like the Next>>.
Patch to follow.
Comment 1 Maxime Pelletier 2012-02-15 21:57:22 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2012-02-23 09:05:43 UTC
Patch does not apply anymore on master.
Can you rebase your patch and resubmit please?
Comment 3 Frédérick Capovilla 2012-02-29 22:08:23 UTC Comment hidden (obsolete)
Comment 4 Koha Team University Lyon 3 2012-03-20 09:48:46 UTC
Vendor invoice and datereceived stay in URL when changing results per page or going to the next page.
Comment 5 Paul Poulain 2012-03-21 17:21:16 UTC
QA comment : tiny patch & good test plan
but  this patch overlap with the DataTable jquery plugin we should/want to use now.
So I think this patch should be rewritten to use the jquery plugin

marking failed QA
Comment 6 Paul Poulain 2012-03-21 17:21:49 UTC
see = wiki.koha-community.org/wiki/DataTables_HowTo
Comment 7 Katrin Fischer 2012-03-21 18:03:57 UTC
Hi Paul, I think so short before feature freeze - perhaps worth fixing the bug and doing the datatables later?
Comment 8 Paul Poulain 2012-03-23 09:24:03 UTC
(In reply to comment #7)
> Hi Paul, I think so short before feature freeze - perhaps worth fixing the
> bug and doing the datatables later?

correct & fair, will push this one now
Comment 9 Jared Camins-Esakov 2012-05-03 23:31:42 UTC
The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6.
Comment 10 Katrin Fischer 2012-06-10 09:29:58 UTC Comment hidden (obsolete)
Comment 11 MJ Ray (software.coop) 2012-06-10 13:08:37 UTC
Created attachment 10096 [details] [review]
Bug 7548: Missing arguments when receiving orders

Patch redone for 3.6.x to fix TT scoping problems and taking care
of changed variable names (booksellerid vs supplierid).

To test:
Check pagination works correctly when receiving orders.
Invoice number and date received should always appear in your URL
and be shown at the top of the website.

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Comment 12 Jared Camins-Esakov 2012-06-14 11:56:00 UTC
This patch will be in 3.6.6.