As can be seen here, record.abs for NORMARC contains wrong line-endings: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/marc_defs/normarc/biblios/record.abs;h=5f6ede79f971c480f4527c8e807933abe1c435c6;hb=HEAD This does not seem to have affected the indexing, since several libraries have been using this file in production for years. But it seems to be causing problems for the fix to bug 7537, so I better fix it!
Created attachment 7711 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r
Created attachment 7712 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r
Created attachment 7753 [details] [review] Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still a few \r But only on comments, safe to push
QA comment: none, magnus will endorse responsibility for any mistake ;-)
Looks good in current master.