Bug 7553 - automated checking that "need signoff" patch still applies
Summary: automated checking that "need signoff" patch still applies
Status: RESOLVED LATER
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Paul Poulain
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 15:09 UTC by Paul Poulain
Modified: 2012-06-11 16:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7553 new script, in a new directory, to automatically check bugzilla need signoff patches (6.61 KB, patch)
2012-02-17 15:12 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2012-02-17 15:09:48 UTC
with the bugz script, we can play with bugzilla bug status. This script check all bugs that "needs signoff", and, at the end, report a list of all those that don't apply.
If you copy/paste this list into bugzilla search you can see all of them

Note that the script is very verbose, but the list appear at the end of the process.
Also note that I planned to automatically update patch status, but bugz don't handle "Patch doesn't apply" status and complain for it. So the script just report the list.
Comment 1 Paul Poulain 2012-02-17 15:12:16 UTC
Created attachment 7735 [details] [review]
Bug 7553 new script, in a new directory, to automatically check bugzilla need signoff patches

with the bugz script, we can play with bugzilla bug status. This script check
all bugs that "needs signoff", and, at the end, report a list of all those that
don't apply.
If you copy/paste this list into bugzilla search you can see all of them

Note that the script is very verbose, but the list appear at the end of the
process.
Also note that I planned to automatically update patch status, but bugz don't
handle "Patch doesn't apply" status and complain for it. So the script just
report the list.
Comment 2 Julian Maurice 2012-02-24 08:54:25 UTC
2 remarks on this new script:

- Because of line 85 "$bugtotest =~ /(....)(.*)/;" and line 87 "if ($bugnumber =~ /\d{4}/) {" it will only handle bug numbers with 4 digits. It's the most common case, but if we make the change now, we will not have to do it when we will reach bug 10000

- "$gitbz = `git bz apply $bugnumber <yyyy`;" Why are you using this file filled with 'y' characters? Isn't 'yes' doing what you want (`yes | git bz apply $bugnumber`) ?
Comment 3 Paul Poulain 2012-03-14 11:17:17 UTC
:'((( i'm disappointed, because it seems that, since bugzilla 4.2 update, this script don't work anymore.

the bugz command that is supposed to retrieve bugs that "needs signoff" now return *all* bugs (yes, 7000+)...
Comment 4 Paul Poulain 2012-03-14 11:21:11 UTC
follow-up =
* trying to search with bugz "REOPENED" bugs is OK
* trying to search with bugz a silly string returns everything

it seems that the webservice now filter status and discard those who are not in the "official/out of the box" status list :(
Comment 5 Paul Poulain 2012-06-11 16:28:11 UTC
The script does not work anymore, I'll try from time to time to check if something has changed on bugzilla or bugz, but until then, marking "RESO LATER"