Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
Summary: Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent dupl...
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords: Academy
Depends on: 4054
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-17 18:28 UTC by Liz Rea
Modified: 2020-11-10 10:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC (10.78 KB, patch)
2017-01-19 22:21 UTC, Gracie
Details | Diff | Splinter Review
Bug 7143: [QA Follow-up] Handling tabs (17.49 KB, patch)
2017-01-19 22:56 UTC, Gracie
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2012-02-17 18:28:26 UTC
When 6496 is pushed, we will have a new jquery function: 
preventDoubleFormSubmit().

When used thusly: $('#form-id').preventDoubleFormSubmit();
It will prevent a submitted form from being submitted a second (or third, or fourth, or fifth) time.

We should probably use this on most submission forms in the OPAC. As Paul states on 6496 - "we can teach librarians not to double click, but not patrons."

The function exists in both the OPAC and Intranet, and so it can be used anywhere a double (or rapid) click would resubmit a form. I think we should try to use it more.
Comment 1 Liz Rea 2012-02-17 18:33:01 UTC
That should read "bug 4054" instead of the 6k one. Updated the depends.
Comment 2 Rochelle Healy 2015-01-13 02:48:20 UTC
I am working on this
Comment 3 Owen Leonard 2016-08-10 15:30:08 UTC
(In reply to Liz Rea from comment #0)
> We should probably use this on most submission forms in the OPAC.

Note that it has since been added to the place hold form in the OPAC.
Comment 4 Gracie 2017-01-19 22:21:58 UTC
Created attachment 59289 [details] [review]
Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC

Test Plan:
- Look at commit to see file changes and then test each form making sure
you can't double submit

This is for the OPAC side
Comment 5 Gracie 2017-01-19 22:23:47 UTC
The above patch is only for half of the bug, I decided to separate the OPAC and Staff sides of the bug to make it easier to see the changes made
Comment 6 Gracie 2017-01-19 22:56:41 UTC
Created attachment 59290 [details] [review]
Bug 7143: [QA Follow-up] Handling tabs

Editing spaces before releases and developer:
876,$s/  \+releases$/^Ireleases/ (20 substitutions)
876,$s/  \+developer$/^Ideveloper/ (7 substitutions on 7 lines)

Editing spaces between date and text:
876,$s/2016  \+/2016^I/
876,$s/2017  \+/2017^I/
Fixed a few single spaces too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Display on Timeline tab looks good now.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Katrin Fischer 2017-05-01 20:00:06 UTC
I am a bit confused by the changes to history.txt in this patch set, can someone explain?
Comment 8 Katrin Fischer 2017-05-01 20:00:40 UTC
I am a bit confused by the changes to history.txt in this patch set, can someone explain?
Comment 9 Fridolin Somers 2020-11-10 10:27:34 UTC
(In reply to Katrin Fischer from comment #8)
> I am a bit confused by the changes to history.txt in this patch set, can
> someone explain?

Same for me.

Forms double submit protection seems really usefull BTW.
Comment 10 Fridolin Somers 2020-11-10 10:42:36 UTC
Can't we add this in all pages via opac-bottom.inc ?