Currently we only support ISBN, but not ISSN in the SearchForTitleIn system preference: "Include a "More Searches" box on the detail pages of items on the OPAC, with the following HTML (leave blank to disable): Note: The placeholders {BIBLIONUMBER}, {CONTROLNUMBER}, {TITLE}, {ISBN} and {AUTHOR} will be replaced with information from the displayed record."
Created attachment 7842 [details] [review] Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t
Created attachment 7843 [details] [review] Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t
Created attachment 7850 [details] [review] Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t Signed-off-by: Magnus Enger <magnus@enger.priv.no> Tested with marcflavour = NORMARC, on one book and one periodical record. * Book - Before the patch: ISSN: {ISSN} ISBN: 0375726446 001: - After the patch: ISSN: ISBN: 0375726446 001: 022976914 * Journal - Before the patch: ISSN: {ISSN} ISBN: 001: - After the patch: ISSN: 1890-6931 ISBN: 001: 080721370 Looks good in all 3 views! Thanks for fixing the 001 thing for NORMARC! Also tested with marcflavour = MARC21, on the same records with the same good results. Signing off!
Clean, consistent patch with unit tests. Fixes some grammar in the notes, and also fixes NORMARC support for 001. All in all, a MARVELOUS patch. Marking Passed QA.
patch pushed, after testing it also work fine for UNIMARC chris_n = I wouldn't object if you decided to apply this for 3.6