Instead of asking the user to type 0 or 1 there should be a Yes/No dropdown for choosing whether a Z39.50 server is checked by default.
Created attachment 7813 [details] [review] Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown
After applying the patch, when adding or editing a Z39.50 server the "checked" option should show a dropdown choice of Yes or No. When editing, the option should be preselected with the correct value. I also updated the table of existing Z39.50 servers to show "Yes" or "No" instead of 1 or 0.
Created attachment 7822 [details] [review] [SIGNED-OFF] Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown I split the <tr> line in your patch for a best visibility. I hope you would agree to this modification.
Not to nit-pick, but wouldn't a single checkbox work just as well here for this boolean choice?
Created attachment 7854 [details] [review] Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox
Created attachment 7872 [details] [review] Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA comment: * small patches, mostly on template * template still valid & translatable passed QA
last patch I pushed yesterday, forgot to update the status
Although I think this is a definite improvement, I am not going to push it to 3.6.x because I would not expect a minor version to make a change to the data entry interface.