Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc.
Summary: Remove unused template markup for css_libs, css_module, js_libs, etc.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 20:19 UTC by Owen Leonard
Modified: 2013-12-05 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc. (4.68 KB, patch)
2012-02-28 20:24 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc. (4.70 KB, patch)
2012-03-02 14:38 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-02-28 20:19:42 UTC
There was a time when it was planned that Koha would automatically load CSS and JS file based on certain contexts. Thus in Auth.pm:

        # load the template variables for stylesheets and JavaScript
        $template->param( css_libs => $in->{'css_libs'} );
        $template->param( css_module => $in->{'css_module'} );
        $template->param( css_page => $in->{'css_page'} );
        $template->param( css_widgets => $in->{'css_widgets'} );

        $template->param( js_libs => $in->{'js_libs'} );
        $template->param( js_module => $in->{'js_module'} );
        $template->param( js_page => $in->{'js_page'} );
        $template->param( js_widgets => $in->{'js_widgets'} );

*_libs would be general libraries like jQuery and YUI. *_module would be files which were specific to "modules" like circulation or cataloging. *_page would be page-specific files, and *_widgets would be things like the calendar widget I suppose.

This method of handling these assets was never implemented and the references to it should be removed.
Comment 1 Owen Leonard 2012-02-28 20:24:20 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2012-03-02 14:38:24 UTC
Created attachment 7988 [details] [review]
[Signed-off] Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc.

Ok, after looking at the code I can confirm that those variables are not used at all.
Signed off.
Comment 3 Jonathan Druart 2012-03-02 15:09:01 UTC
Marked as Passed QA. No regression with this patch.
Comment 4 Jared Camins-Esakov 2012-05-23 23:56:22 UTC
Will not be pushed to 3.6.x. Trivial patch, but with a small chance of causing a regression.