Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow
Summary: error when trying to email cart when opacuserlogin set to don't allow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low major
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 19:11 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
error message (39.33 KB, image/jpeg)
2012-03-01 19:11 UTC, Nicole C. Engard
Details
Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow (7.00 KB, patch)
2012-03-01 20:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow (7.25 KB, patch)
2012-03-03 16:29 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-03-01 19:11:31 UTC
Created attachment 7974 [details]
error message

When a library doesn't allow logging in to the OPAC the error that pops up when trying to email the cart is a mess.  The message links to what is supposed to be the admin email address, but the address is not there on the link.  It also mentions a menu at the top that may or may not be there.  This error should be cleaned up and the email link should actually email the administrator.

I know that you have to log in to email the cart - this bug is not about that - it's just a design issue that needs resolving.
Comment 1 Nicole C. Engard 2012-03-01 19:12:47 UTC
Also, the search box is at the top and doesn't fit in the tiny window - now sure if we need/want the search box to be in that error message pop up.
Comment 2 Nicole C. Engard 2012-03-01 19:16:55 UTC
Another option is to hide the email button if this preference is set to not allow people to log in to the OPAC.
Comment 3 Owen Leonard 2012-03-01 20:08:50 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2012-03-01 20:49:00 UTC
Owen,

After applying if I allow logins I can't click the send email link in the cart.  Nothing seems to be happening when I click on it.

Do you see this happening? or could it be my browser?

Nicole
Comment 5 Jared Camins-Esakov 2012-03-03 16:29:33 UTC
Created attachment 8000 [details] [review]
Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow

This patch hides the "send cart" link if the opacuserlogin
preference is set to disallow. Other similar changes included:

- hide the "send list" link
- hide the "your lists" tab
- hide the "log in to create your own lists" link
- hide the "recent comments" link

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Tested with opacuserlogin set to both "Allow" and "Don't allow." With
opacuserlogin set to "Allow," the links showed up, and with opacuserlogin
set to "Don't allow," the links did not.
Comment 6 Nicole C. Engard 2012-03-03 16:56:21 UTC
Jared,

No one commented on my finding - did you try to email the cart when you were allowed to?

Nicole
Comment 7 Jared Camins-Esakov 2012-03-03 17:05:14 UTC
Whoops, I meant to say "the links showed up and worked." Sending the e-mail worked as well as could be expected, on a system that doesn't have any outgoing e-mail (i.e. I got another bounce on the VM).
Comment 8 Ian Walls 2012-03-09 20:12:14 UTC
Template only change to add checks for whether OPAC logins are allowed before presenting some of the logged-in OPAC tools.  Marking as Passed QA.
Comment 9 Jared Camins-Esakov 2012-05-09 16:53:21 UTC
This bug will be included in the Koha 3.6.5 release.