Created attachment 7974 [details] error message When a library doesn't allow logging in to the OPAC the error that pops up when trying to email the cart is a mess. The message links to what is supposed to be the admin email address, but the address is not there on the link. It also mentions a menu at the top that may or may not be there. This error should be cleaned up and the email link should actually email the administrator. I know that you have to log in to email the cart - this bug is not about that - it's just a design issue that needs resolving.
Also, the search box is at the top and doesn't fit in the tiny window - now sure if we need/want the search box to be in that error message pop up.
Another option is to hide the email button if this preference is set to not allow people to log in to the OPAC.
Created attachment 7975 [details] [review] Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow This patch hides the "send cart" link if the opacuserlogin preference is set to disallow. Other similar changes included: - hide the "send list" link - hide the "your lists" tab - hide the "log in to create your own lists" link - hide the "recent comments" link
Owen, After applying if I allow logins I can't click the send email link in the cart. Nothing seems to be happening when I click on it. Do you see this happening? or could it be my browser? Nicole
Created attachment 8000 [details] [review] Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow This patch hides the "send cart" link if the opacuserlogin preference is set to disallow. Other similar changes included: - hide the "send list" link - hide the "your lists" tab - hide the "log in to create your own lists" link - hide the "recent comments" link Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tested with opacuserlogin set to both "Allow" and "Don't allow." With opacuserlogin set to "Allow," the links showed up, and with opacuserlogin set to "Don't allow," the links did not.
Jared, No one commented on my finding - did you try to email the cart when you were allowed to? Nicole
Whoops, I meant to say "the links showed up and worked." Sending the e-mail worked as well as could be expected, on a system that doesn't have any outgoing e-mail (i.e. I got another bounce on the VM).
Template only change to add checks for whether OPAC logins are allowed before presenting some of the logged-in OPAC tools. Marking as Passed QA.
This bug will be included in the Koha 3.6.5 release.