Bug 7652 - add item barcode on top of its editing form
Summary: add item barcode on top of its editing form
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement
Assignee: Koha Team University Lyon 3
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 10:21 UTC by Koha Team University Lyon 3
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
add item barcode on top of its editing form (1.01 KB, patch)
2012-03-06 10:21 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
add item barcode on top of its editing form (1.55 KB, patch)
2012-03-06 18:10 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
barcode on top of item edit form (120.40 KB, image/jpeg)
2012-05-23 08:33 UTC, Koha Team University Lyon 3
Details
signed off patch (1.59 KB, patch)
2012-06-09 10:13 UTC, Adrien SAURAT
Details | Diff | Splinter Review
Signed-off patch (1.58 KB, patch)
2012-06-09 10:21 UTC, Adrien SAURAT
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2012-03-06 10:21:30 UTC Comment hidden (obsolete)
Comment 1 Owen Leonard 2012-03-06 16:10:41 UTC
Doesn't this require a change to the script in order for it to work? As it is the 'barcode' variable is only available inside [% FOREACH ite IN item %].

I don't see any barcode displayed when editing an item.
Comment 2 Koha Team University Lyon 3 2012-03-06 18:10:41 UTC Comment hidden (obsolete)
Comment 3 Koha Team University Lyon 3 2012-03-06 18:13:10 UTC
Oups !  you are right, here's the missing line (in the new patch).
additem.pl line 741
barcode => GetBarcodeFromItemnumber($itemnumber)
Comment 4 Leila 2012-03-21 14:30:27 UTC
Hello,

I didn't see the item barcode on top of the form of item creation (/
koha/cataloguing/additem.pl?biblionumber=2).
Test with a database in marc21.

Sorry
Comment 5 Koha Team University Lyon 3 2012-03-21 15:42:28 UTC
Well, you are right, it's not visible in creation... since in creation there's no barcode yet. But it should be visible in modification
Comment 6 Koha Team University Lyon 3 2012-05-23 08:33:09 UTC
Created attachment 9737 [details]
barcode on top of item edit form

Test plan :
1) take an existing item with an existing barcode and search for it in the pro catalog. 
2) click on Items tab then on "Edit item" link

the barcode number is now displayed on top of the form (see attached image)
Comment 7 Adrien SAURAT 2012-06-09 10:13:51 UTC Comment hidden (obsolete)
Comment 8 Adrien SAURAT 2012-06-09 10:21:15 UTC
Created attachment 10002 [details] [review]
Signed-off patch

(fixed Author)
Comment 9 Paul Poulain 2012-06-10 09:49:29 UTC
QA comment: tiny patch, that probably add some overhead because of GetBarcodeFromItemnumber sub, that queries SQL, but that's the proper way to handle this feature.

Passes QA