C4::tests just includes a C4::Record unit test. I am moving it to t/db_dependent/Record. Note: When I tested this, it fails tests 4 and 7 (2 from 23). This is already the case in master now, so outside the scope of this report.
Created attachment 8055 [details] [review] Patch
Created attachment 8067 [details] [review] 7661 Moving C4::tests to unit tests This is only a file moving patch. No behaviour changes. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Ran tests, new tests were performed as expected.
I believe t/db_dependent/Record/Record.t is redundant; there is a nearly identical file in t/db_dependent with the same name.
(In reply to comment #3) > I believe t/db_dependent/Record/Record.t is redundant; there is a nearly > identical file in t/db_dependent with the same name. I just had a quick glance through that file and chose the careful path: move the work of someone else to a more appropriate location instead of deleting it rightaway. You are of course welcome to dig deeper and get the best of both in one test. Please send a followup ;)
Fair enough. This patch just moves files, no regressions found. Cleanup for tests can be accomplished in a follow up. Marking as Passed QA.
mmm... isn't the 31.36KB patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8055) really obsoleted ? I think it's a mistake, could you confirm ?
(In reply to comment #6) > mmm... isn't the 31.36KB patch > (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8055) really > obsoleted ? I think it's a mistake, could you confirm ? Think it's okay. Obsoleted by signoff. The newer git version creates a smaller patch file.
trying to prove t/db_dependent/Record/Record.t after applying the patch, I get a nasty: t/db_dependent/Record/Record.t .. 1/23 Aucun fichier ou dossier de ce type at t/db_dependent/Record/Record.t line 46. # Looks like you planned 23 tests but ran 1. # Looks like your test exited with 2 just after 1. t/db_dependent/Record/Record.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 22/23 subtests Test Summary Report ------------------- t/db_dependent/Record/Record.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 23 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.37 cusr 0.03 csys = 0.45 CPU) Result: FAIL What's wrong ? I also had a problem applying the patch: git bz apply 7661 Bug 7661 - Moving C4::tests to unit tests 7661 Moving C4::tests to unit tests Apply? [yn] y Applying: 7661 Moving C4::tests to unit tests Can't open perl script "C4/tests/Record_test.pl": Aucun fichier ou dossier de ce type Are you sure you want to commit ? You can commit with the --no-verify argument Patch left in /tmp/7661-Moving-C4tests-to-unit-tests-EEw6sJ.patch that was caused by the pre-apply hook I think, I had to force --no-verify I'll push it, we will see if things are OK on jenkins, but I have some doubts.
Will send a followup shortly. Tested it in its Record subdirectory. From the root it does not work.
Created attachment 8201 [details] [review] Followup patch
Back to Passed QA for trivial followup resolving path and commenting out the two failing tests.
follow-up pushed. The tests are now OK for me.