When you edit a framework to make subfields in the 952 required these feels show in the edit item screen with little black stars. Can we make those red like they are on the bib cataloging screen?
Created attachment 8088 [details] [review] Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note.
Created attachment 8093 [details] [review] Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes tests, works as advertised.
Template and CSS only change that increases readability and customizability. Marking as Passed QA.
QA comment: If you try to save without entering a mandatory field, the highlighting is made "light red on dark red", that's quite hard to read. If I compare the result with the addbiblio.pl file, it's not consistent (in addbiblio.pl, an empty mandatory field become yellow, the description is not updated) Could you do improve your patch a little bit more ? (not marking failed QA, if you say "no", i'll push it as it is, and yell that you're the one to blame if someone complain :D :D )
Created attachment 8190 [details] [review] Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background.
Created attachment 8191 [details] [review] Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works - passes tests.
Still just a template/CSS change, but now with better highlighting. Moving back to Passed QA.
(In reply to comment #5) > This patch also corrects an error in the client-side validation > script which misidentified which fields were required. Leaving > a required field empty should result in an alert and the missing > field being highlighted in yellow. well done owen ! I had noticed the problem, but thought it was due to some specific setup I had.
Created attachment 8247 [details] [review] Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works - passes tests. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Whoops, git-bz accident there, ignore me.
This patch will be included in 3.6.5.