Compatibility of CSS gradients in Internet Explorer is looking worse than I expected. I propose to remove the gradient from these elements in favor of a solid background: - Cart and Lists buttons : Applying a background gradient to these elements causes the background to "bleed" out of the rounded corners in IE9 creating an ugly halo. - Lists menu and patron menu items : These elements use gradients which in standards-compliant browsers accept several "steps" (color 1 blended with color 2 blended with color 3). IE only understands two colors. Better to have a solid background than the inferior fallback IE ends up with.
Created attachment 13122 [details] [review] Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon.
Created attachment 13336 [details] [review] Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I tested this in Firefox, and Chromium and it didn't break anything, I trust it works for IE too.
QA comment * css only small patch * don't break anything on FF afaics passed QA
Created attachment 13779 [details] [review] Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I tested this in Firefox, and Chromium and it didn't break anything, I trust it works for IE too. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x, will be in 3.10.1