Bug 7697 - Clean up borrower.textmessaging leftover code
Summary: Clean up borrower.textmessaging leftover code
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low trivial (vote)
Assignee: Ian Walls
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-10 17:02 UTC by Ian Walls
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7697: Remove unused textmessaging parameter from OPAC main/user (2.01 KB, patch)
2012-03-10 17:06 UTC, Ian Walls
Details | Diff | Splinter Review
Bug 7697: Remove unused textmessaging parameter from OPAC main/user (2.11 KB, patch)
2012-03-10 18:44 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2012-03-10 17:02:35 UTC
opac/opac-main.pl and opac/opac-user.pl export a template param 'textmessaging', based on the database field borrower.textmessaging, which does not exist in Koha 3.X.  While this is generally harmless, it does add a dependency on C4/Members to opac/opac-main.pl, which goes nowhere and does nothing.
Comment 1 Ian Walls 2012-03-10 17:06:48 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-03-10 18:44:59 UTC
Created attachment 8149 [details] [review]
Bug 7697: Remove unused textmessaging parameter from OPAC main/user

Removes the textmessaging parameter from opac/opac-main.pl and
opac/opac-user.pl, since it's not utilized anywhere in the templates, and is
sourced from a field that no longer exists in the borrower
table (textmessaging).

This also removes a dependency on C4/Members.pm from opac-main.pl

To Test:  Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both
pages should still render properly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 3 Marcel de Rooy 2012-03-19 18:53:01 UTC
Looks good to me. Marking as Passed QA.
Comment 4 Paul Poulain 2012-03-20 15:52:52 UTC
Patch pushed

I also have checked that opac note & patron message are still here, they are
Comment 5 Jared Camins-Esakov 2012-12-31 00:43:42 UTC
There have been no further reports of problems so I am marking this bug resolved.