opac/opac-main.pl and opac/opac-user.pl export a template param 'textmessaging', based on the database field borrower.textmessaging, which does not exist in Koha 3.X. While this is generally harmless, it does add a dependency on C4/Members to opac/opac-main.pl, which goes nowhere and does nothing.
Created attachment 8147 [details] [review] Bug 7697: Remove unused textmessaging parameter from OPAC main/user Removes the textmessaging parameter from opac/opac-main.pl and opac/opac-user.pl, since it's not utilized anywhere in the templates, and is sourced from a field that no longer exists in the borrower table (textmessaging). This also removes a dependency on C4/Members.pm from opac-main.pl To Test: Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both pages should still render properly.
Created attachment 8149 [details] [review] Bug 7697: Remove unused textmessaging parameter from OPAC main/user Removes the textmessaging parameter from opac/opac-main.pl and opac/opac-user.pl, since it's not utilized anywhere in the templates, and is sourced from a field that no longer exists in the borrower table (textmessaging). This also removes a dependency on C4/Members.pm from opac-main.pl To Test: Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both pages should still render properly. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Looks good to me. Marking as Passed QA.
Patch pushed I also have checked that opac note & patron message are still here, they are
There have been no further reports of problems so I am marking this bug resolved.