Created attachment 8154 [details] screenshot The "More Details" view of the cart in OPAC shows too many subfields. Especially identity numbers from $0 subfields are not interesting for the user.
Created attachment 8161 [details] [review] Bug 7700: Cart's more details view shows identity numbers We already remove $9 with Koha's authority number from output of GetMarcSubjects and GetMarcAuthors. Patch additionally removes $0 subfields with identity numbers. Patch also effects detail pages with normal (non-XSLT) views.
Created attachment 8168 [details] [review] Bug 7700: Cart's more details view shows identity numbers We already remove $9 with Koha's authority number from output of GetMarcSubjects and GetMarcAuthors. Patch additionally removes $0 subfields with identity numbers. Patch also effects detail pages with normal (non-XSLT) views. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Strips out MARC21 subfield 0 in subjects and authors in normal view. Since this is pretty solidly always undesirable information to display, I think this filteration is okay. It would be better to have something universally configurable, but that's a much grander project. Marking as Passed QA.
QA comment : won't push this patch immediatly, as I think it's also relevant for UNIMARC, so the patch could be simpler ;-) ccing one of BibLibre librarians. Gaetan/Stéphane/francois, your opinion: couldn't we also remove $0 when building subjects/authors ?
Didn't want to break something - so was super careful here :)
I've tested it very quickly on a two instances (Paul : Cherbourg and Aix-Marseille), and the numbers identifying the authorities are not showing.
The unimarc the authority number is in 6XX, 7XX $3 inside the bibliographic notices not in $0. And in $9 it is the number koha oh the authority.
Hi, thx for checking! So should $3 be removed from the display for UNIMARC? Is $0 used at all in UNIMARC? Could/Should it be removed for UNIMARC or only for MARC21?
in this case yes you can remove the $0 the $0 is not used in UNIMARC
failed QA until a patch not specific to MARC21 is provided (ie= no need to specify marcflavour eq "MARC21"). I also think NORMARC will prefer a non-MARC21 specific patch, because NORMARC is close to MARC21, and the 0 is probably to remove as well
Created attachment 8341 [details] [review] [revised] Bug 7700: Cart's more details view shows identity numbers We already remove $9 with Koha's authority number from output of GetMarcSubjects and GetMarcAuthors. Patch additionally removes $0 subfields with identity numbers. Patch also effects detail pages with normal (non-XSLT) views. Revised to always remove $0 subfields, they are not used in UNIMARC.
Created attachment 8344 [details] [review] Bug 7700: Cart's more details view shows identity numbers We already remove $9 with Koha's authority number from output of GetMarcSubjects and GetMarcAuthors. Patch additionally removes $0 subfields with identity numbers. Patch also effects detail pages with normal (non-XSLT) views. Revised to always remove $0 subfields, they are not used in UNIMARC. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA comment: tiny patch, no specific comment
This bug will be included in the Koha 3.6.5 release.