Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that when SendAlerts is called (exactly when this happens is a mystery to me), you will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to C4::Letters:: should fix it.
Created attachment 8156 [details] [review] Bug 7701: Error when sending serial alerts Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that when SendAlerts is called (exactly when this happens is a mystery to me), you will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to C4::Letters:: should fix it.
Created attachment 8663 [details] [review] [SIGNED-OFF] Bug 7701: Error when sending serial alerts Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that when SendAlerts is called (exactly when this happens is a mystery to me), you will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to C4::Letters:: should fix it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the perl error. Steps to reproduce: 1) Create a subscription and set patron notification to "Routling list" - this is necessary, so that a link to email notifications shows up in the OPAC. 2) Search for the serial record in the OPAC and click on the more details view from the subscriptions tab. Subscribe to email notifications. 3) Go back into the serials module and receive and issue for the serial. Before the patch a nasty perl error will be shown, after the patch receiving works. I couldn't confirm that the email was sent out with my setup, but this patch certainly fixes serial receive.
I am changing the severity because without the patch serial receive does not work when you have a patron subscribed to alerts for new serial issues.
Are you both sure that this is the fix: C4::Leters::SendAlerts ?? Changing to Failed QA. Please correct.
Good catch Marcel - perhaps would not send a mail in that case but stop the Perl error? I could only check the receive part.
Created attachment 8679 [details] [review] [SIGNED-OFF] Bug 7701: Error when sending serial alerts Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that when SendAlerts is called (exactly when this happens is a mystery to me), you will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to C4::Letters:: should fix it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the perl error. Steps to reproduce: 1) Create a subscription and set patron notification to "Routling list" - this is necessary, so that a link to email notifications shows up in the OPAC. 2) Search for the serial record in the OPAC and click on the more details view from the subscriptions tab. Subscribe to email notifications. 3) Go back into the serials module and receive and issue for the serial. Before the patch a nasty perl error will be shown, after the patch receiving works. I couldn't confirm that the email was sent out with my setup, but this patch certainly fixes serial receive. [Update 2011-02-29] Fixed the typo and retested. Looks good, but couldn't check if the mail was actually sent.
Looks even better ;)
I pushed the patch because it fixes an obvious problem, but please test ! Katrin, you should have had a Perl error when trying to run C4::Leters::SendAlerts. If you hadn't then it's probably that those lines have not been executed
:( I am not sorry what went wrong in my tests, but I am worried about getting no email. I know this used to work on our 3.2.2 installations and want to do more tests, but not sure when I will have the time. Could someone with working email setup test on master and report of a mail is sent or not? The template used normally is RLIST. I noted the test plan in my sign off comment.
Retested this and sending out serial alerts works perfectly fine (see bug 7658)