Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs
Summary: NORMARC XSLT OPAC detail view shows double tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Magnus Enger
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 14:55 UTC by Magnus Enger
Modified: 2013-12-05 19:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing double tabs (34.19 KB, image/png)
2012-03-16 14:55 UTC, Magnus Enger
Details
Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs (2.00 KB, patch)
2012-03-23 15:02 UTC, Magnus Enger
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs (2.02 KB, patch)
2012-03-24 15:32 UTC, Marijana Glavica
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2012-03-16 14:55:47 UTC
Created attachment 8232 [details]
Screenshot showing double tabs

When 

marcflavour = NORMARC
OPACXSLTDetailsDisplay = use XSLT

the detail view has a double set of tabs for different views of the MARC record - see attached screenshot.
Comment 1 Magnus Enger 2012-03-23 15:02:36 UTC Comment hidden (obsolete)
Comment 2 Marijana Glavica 2012-03-24 15:32:09 UTC
Created attachment 8620 [details] [review]
[SIGNED-OFF] Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs

With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT,
the detail view displays a double set of tabs for Normal/MARC/ISBD
views, one above the title and one below.

To test:
marcflavour = NORMARC
OPACXSLTDetailsDisplay = Using XSLT

Since the contents of the recaords do not matter here, the patch
can be tested on MARC records of any flavour.

- Check that double tabs are shown
- Apply the patch
- Check that only the set of tabs at the top is shown

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Comment 3 Marijana Glavica 2012-03-24 15:35:24 UTC
Notice about multilanguage issue:
non-english NORMARCslim2OPACDetail.xsl is located in english directory!
Comment 4 Magnus Enger 2012-03-27 19:40:19 UTC
(In reply to comment #3)
> Notice about multilanguage issue:
> non-english NORMARCslim2OPACDetail.xsl is located in english directory!

Thanks for signing off! 

Actually there is just the English directory to choose from: 
http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/prog

The other directories get created, and the XSLT-files get copied over, when you install more languages. 

And translating the NORMARC stuff into English and then back again to Norwegian makes no sense, I'm afraid...
Comment 5 Marijana Glavica 2012-03-27 21:29:05 UTC
(In reply to comment #4)
> Actually there is just the English directory to choose from: 
> http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-
> tmpl/prog
>
> The other directories get created, and the XSLT-files get copied over, when
> you install more languages. 

Yes, and that is why all templates should originally be written in English :)

> And translating the NORMARC stuff into English and then back again to
> Norwegian makes no sense, I'm afraid...

unless you want to use NOMARC in multi-lingual environment :)
Comment 6 Magnus Enger 2012-03-28 08:48:27 UTC
(In reply to comment #5)
> unless you want to use NOMARC in multi-lingual environment :)

Hopefully, NORMARC will be dead long before that happens... ;-)
Comment 7 Marcel de Rooy 2012-03-28 11:53:47 UTC
QA Comment: Approving this change. Probably you would like to compare this xslt with the MARC21 counterpart in order to check if you missed more changes. For the record just mentioning that leaving Norwegian words in this English file is IMO not preferred. (Understand the pragmatic approach, but at the end we could have all languages in the English startup.) This patch does not add such words, but removes them. Great ;)
Comment 8 Paul Poulain 2012-03-28 14:20:51 UTC
pushed, not tested myself, but looking at the patch, should not be wrong.
Comment 9 Magnus Enger 2012-04-16 16:45:51 UTC
Fixed in current master.
Comment 10 Jared Camins-Esakov 2012-05-09 20:03:04 UTC
This bug will be included in the Koha 3.6.5 release.