Created attachment 8232 [details] Screenshot showing double tabs When marcflavour = NORMARC OPACXSLTDetailsDisplay = use XSLT the detail view has a double set of tabs for different views of the MARC record - see attached screenshot.
Created attachment 8604 [details] [review] Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT, the detail view displays a double set of tabs for Normal/MARC/ISBD views, one above the title and one below. To test: marcflavour = NORMARC OPACXSLTDetailsDisplay = Using XSLT Since the contents of the recaords do not matter here, the patch can be tested on MARC records of any flavour. - Check that double tabs are shown - Apply the patch - Check that only the set of tabs at the top is shown
Created attachment 8620 [details] [review] [SIGNED-OFF] Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT, the detail view displays a double set of tabs for Normal/MARC/ISBD views, one above the title and one below. To test: marcflavour = NORMARC OPACXSLTDetailsDisplay = Using XSLT Since the contents of the recaords do not matter here, the patch can be tested on MARC records of any flavour. - Check that double tabs are shown - Apply the patch - Check that only the set of tabs at the top is shown Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Notice about multilanguage issue: non-english NORMARCslim2OPACDetail.xsl is located in english directory!
(In reply to comment #3) > Notice about multilanguage issue: > non-english NORMARCslim2OPACDetail.xsl is located in english directory! Thanks for signing off! Actually there is just the English directory to choose from: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/prog The other directories get created, and the XSLT-files get copied over, when you install more languages. And translating the NORMARC stuff into English and then back again to Norwegian makes no sense, I'm afraid...
(In reply to comment #4) > Actually there is just the English directory to choose from: > http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac- > tmpl/prog > > The other directories get created, and the XSLT-files get copied over, when > you install more languages. Yes, and that is why all templates should originally be written in English :) > And translating the NORMARC stuff into English and then back again to > Norwegian makes no sense, I'm afraid... unless you want to use NOMARC in multi-lingual environment :)
(In reply to comment #5) > unless you want to use NOMARC in multi-lingual environment :) Hopefully, NORMARC will be dead long before that happens... ;-)
QA Comment: Approving this change. Probably you would like to compare this xslt with the MARC21 counterpart in order to check if you missed more changes. For the record just mentioning that leaving Norwegian words in this English file is IMO not preferred. (Understand the pragmatic approach, but at the end we could have all languages in the English startup.) This patch does not add such words, but removes them. Great ;)
pushed, not tested myself, but looking at the patch, should not be wrong.
Fixed in current master.
This bug will be included in the Koha 3.6.5 release.