Created attachment 8272 [details] cardnumber instead of name showing When I have HidePatronName set to SHOW it's not showing the patron name on the moredetail page anymore, it only shows the barcode no matter what I set the preference to. The info is showing right on the detail page.
Created attachment 9205 [details] [review] Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty.
Created attachment 9209 [details] label in funny place The patch applies and shows the name right, but if the book is not checked out it puts the 'current renewals' label next to 'checkout status' instead of below it.
Created attachment 9211 [details] [review] Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty.
It was a missing  . :)
Created attachment 9213 [details] [review] [SIGNED-OFF] Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Adds borrower name information to catalogue/moredetail if the system preference is set to show the patron name (keeps existing behavior of showing cardnumber otherwise). Cleans up spacing, and adds conditional checks for several variables before trying to display them. While technically out of scope for this bug report, these are minor changes and definite improvements, so they'll be given a pass. Marking Passed QA.
The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6.