Bug 7734 - NO_LIBRARY_SET should be translatable
Summary: NO_LIBRARY_SET should be translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low enhancement
Assignee: Katrin Fischer
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 13:14 UTC by Katrin Fischer
Modified: 2013-12-05 19:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 7734: NO_LIBRARY_SET should be translatable (1.47 KB, patch)
2012-03-19 13:40 UTC, Katrin Fischer 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7734: NO_LIBRARY_SET should be translatable (1.56 KB, patch)
2012-03-20 19:27 UTC, Marc Véron 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-03-19 13:14:19 UTC 
This was reported on the wiki (http://wiki.koha-community.org/wiki/Yet_not_translatable_string)

When you are logged in as "root" user, Koha will display NO_LIBRARY_SET in the upper right corner, which is not translatable.
Comment 1 Katrin Fischer 2012-03-19 13:40:50 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2012-03-20 19:27:01 UTC 
Created attachment 8378 [details] [review]
[SIGNED-OFF] Bug 7734: NO_LIBRARY_SET should be translatable

To test:
- Make sure you are logged into Koha as 'root' user - not superlibrarian
- Before the patch the label will show 'NO_LIBRARY_SET', after applying
  the patch it will be 'NO LIBRARY SET' without underscores.
- Verify correct description is shown after selecting a library.

Signed-off-by: mveron <veron@veron.ch>
Comment 3 Marc Véron 2012-03-20 19:28:28 UTC 
Test worked as described, "NO LIBRARY SET" without underscores.
Comment 4 Ian Walls 2012-03-20 22:57:33 UTC 
Template only change, simple conditional, increases translatability.  Marking Passed QA.
Comment 5 Owen Leonard 2012-03-22 08:20:54 UTC 
Translations will have to be updated, but this is working correctly now.
Comment 6 Jared Camins-Esakov 2012-05-09 20:04:24 UTC 
This bug will be included in the Koha 3.6.5 release.