This again was reported on the wiki (http://wiki.koha-community.org/wiki/Yet_not_translatable_string). When you configure a subfield in the bibliographic marc frameworks the "Display more contraints" has some translation problems. 1) After the page was loaded, it will appear translated. 2) Clicking on the link will make the additional constraints show, but untranslates the link. 3) Clicking on it again will hide the options, but the link remains untranslated. Additionally, the labels for 'hide' and 'display' are switched. Tested with de-DE on current master.
Created attachment 8296 [details] [review] Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable The Javascript toggling the link description was checking for the english link text. This would not work for translated templates. To test: - Use translated non english templates (de-DE, fr-Fr...) - Go to: Administration > Bibliographic MARC frameworks - Select any framework's MARC structure - Choose any field and edit the subfields - Check toggling the 'more constraints' for subfields works correctly and the link description changes accordingly.
Created attachment 8435 [details] [review] [SIGNED-OFF] Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable The Javascript toggling the link description was checking for the english link text. This would not work for translated templates. Tested: Apply patch, then translate update and translate install. Text changes as appropriate (with manually inserted translation in .po file) Signed-off-by: mveron <veron@veron.ch>
Template only change for translatability. Marking Passed QA
This patch also fix tab indentation, great job !
Translations still need to be updated, but this looks like it's working correctly now.
This bug will be included in the Koha 3.6.5 release.