In order to make the transition to jQueryUI easier to test and get approval for, I will submit my jQueryUI work one "widget" at a time: autocomplete, tabs, datepicker, etc. First will be autocomplete as it touches the fewest files.
Created attachment 9368 [details] [review] Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up.
Created attachment 9741 [details] [review] Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447
Created attachment 9742 [details] [review] Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes all tests outlined, is quite pretty. Passes t xt
Created attachment 9784 [details] [review] [PASSED QA] Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes all tests outlined, is quite pretty. Passes t xt Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Primarily a template-level patch, but with some underlying implementation changed for the auto-complete scripts. Looks much, much better. Search for patrons is done more efficiently now, but with less flexibility. I think that's a reasonable tradeoff considering this is the auto-complete, and needs to be fast. Marking Passed QA.
QA comment: This patch applies smoothly, and seems to work, but I've a question before pushing. It adds many sprite images: create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_222222_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_2e83ff_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_454545_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_888888_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_cd0a0a_256x240.png What's the use of those images ? Can/should they be used in other places of Koha ?
Created attachment 9835 [details] [review] Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This follow-up removes the default jQueryUI images and amends the staff client CSS to override calls to those images with a "Koha-native" style.
(In reply to comment #7) > This follow-up removes the default jQueryUI images and amends the staff > client CSS to override calls to those images with a "Koha-native" style. Thanks !
Created attachment 9880 [details] [review] Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves.
Created attachment 10047 [details] [review] [SIGNED-OFF] Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves. First two work perfectly, circulation search header and overdues patron authorized value. Authorities search does not seem to work, old yui file are still referenced in auth_finder.tt. The jquery works, but data set is not found, or I messed up my authority record. Signed-off-by: Koha <koha@koha.(none)>
I would apply this, and open a new bug to resolve the authorities autocomplete search and to remove the redundant js files from auth_finder.tt
QA comment: removing code-only path, nothing to object from QA point of view :D Note the signoff-er name does not appear, i'll fix it when pushing
(In reply to comment #11) > I would apply this, and open a new bug to resolve the authorities > autocomplete search and to remove the redundant js files from auth_finder.tt Agreed. Patch pushed, please provide follow-up in another bug (that could usefully be marking as dependant on this one)
I've submitted a follow-up in Bug 8241. > Authorities search does not seem to work It's working fine for me, so please re-test.
There have been no further reports of problems so I am marking this bug resolved.