Bug 7749 - Not all OKs on the start page are translatable
Summary: Not all OKs on the start page are translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal
Assignee: Katrin Fischer
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 16:56 UTC by Katrin Fischer
Modified: 2013-12-05 19:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 7749: Not all OKs on the start page are translatable (1.32 KB, patch)
2012-03-19 17:13 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 7749: Not all OKs on the start page are translatable (1.36 KB, patch)
2012-03-20 17:57 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7749: Not all OKs on the start page are translatable (1.41 KB, patch)
2012-03-20 18:54 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-03-19 16:56:52 UTC
This also was reported on the wiki (http://wiki.koha-community.org/wiki/Yet_not_translatable_string)

On Koha's start page not all OK's buttons will be translated. The OK button for OPAC search is not translatable.
Comment 1 Katrin Fischer 2012-03-19 17:13:13 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2012-03-20 17:57:36 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2012-03-20 18:54:17 UTC
Created attachment 8377 [details] [review]
[SIGNED-OFF] Bug 7749: Not all OKs on the start page are translatable

I don't really understand, why the " OK " would not get picked up by
the translation script, but removing the spaces made it work.

To test:
Verify that all OK buttons on the start page are translatable. The one
resisting translation was "Search catalog:"

Signed-off-by: mveron <veron@veron.ch>
Comment 4 Marc Véron 2012-03-20 18:55:45 UTC
How I tested:

Code near Search catalog (before applying patch)
<input value=" OK " class="submit" type="submit">

After applying patch:
<input value="OK" class="submit" type="submit">

Blanks around OK are gone.
Comment 5 Ian Walls 2012-03-20 19:21:21 UTC
Trivial change to a template, removing two spaces.  Marking Passed QA.
Comment 6 Jared Camins-Esakov 2012-05-09 20:03:11 UTC
This bug will be included in the Koha 3.6.5 release.