Bug 7752 - itemcallnumber not being displayed
Summary: itemcallnumber not being displayed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: 3.4
Hardware: All All
: P5 - low normal (vote)
Assignee: Ian Walls
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 03:18 UTC by Nicholas van Oudtshoorn
Modified: 2012-10-25 23:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch to actually show the call number in the self-checkout issues list (1.69 KB, patch)
2012-03-20 07:01 UTC, Nicholas van Oudtshoorn
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas van Oudtshoorn 2012-03-20 03:18:43 UTC
When using the self checkout, the item callnumber is not being displayed. Rather, it's default is being set. A simple change fixes it:

Changing:
[% DEFAULT ISSUE.itemcallnumber=" " %]

To: 
[% DEFAULT ISSUE.itemcallnumber="&nbsp;" %] [% ISSUE.itemcallnumber %]<
Comment 1 Chris Cormack 2012-03-20 03:20:46 UTC
Hi Nicholas

Would you like to have a go at creating a patch to fix this? Or would you like me to format this into a patch for you?
Comment 2 Nicholas van Oudtshoorn 2012-03-20 07:01:11 UTC
Created attachment 8329 [details] [review]
Patch to actually show the call number in the self-checkout issues list

This patch actually echoes the item call number in self-checkout mode.
Comment 3 Nicholas van Oudtshoorn 2012-03-20 07:05:19 UTC
(In reply to comment #1)
> Hi Nicholas
> 
> Would you like to have a go at creating a patch to fix this? Or would you
> like me to format this into a patch for you?

Hi Chris,

Hopefully the attached patch is ok. Related to this fix, is anyone working on improving the css/templating of the SCO? On our box, we've used css to do things like highlighting rows - which makes for (arguably!) much nicer html code... if it's of use, we could easily send it in....
Comment 4 Nicholas van Oudtshoorn 2012-03-20 07:08:23 UTC
Just checked (should have done this sooner!): It's already fixed in master...
Comment 5 Chris Cormack 2012-03-20 07:12:10 UTC
Ahh, now your next mission is to find the bug that has the fix on it, make comment on it, so the Release Maintainer can pull it into the 3.4.x branch if they decide to :)
Comment 6 Chris Cormack 2012-03-20 07:12:40 UTC
Good practice for making a patch though :)
Comment 7 Nicholas van Oudtshoorn 2012-03-20 08:03:53 UTC
Found it! (6640) - and it's already been pushed to 3.4.5. I blame it on all the cosmetic patches in our tree... we'd have ugpraded long ago otherwise! :-P