Bug 7784 - Improve clarity of batch modification operations
Summary: Improve clarity of batch modification operations
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/tools/batchMod.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-21 16:08 UTC by Owen Leonard
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7784 - Improve clarity of batch modification operations (5.37 KB, patch)
2012-08-20 18:16 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7784 - Improve clarity of batch modification operations (5.42 KB, patch)
2012-08-20 19:38 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-03-21 16:08:12 UTC
In the batch item modification interfaces:

"Checking the box right next the subfield label will disable the entry 
and delete the values of that subfield on all selected items"

I think it's more accurate to say "disable the entry and delete the contents of the subfield." Some enhancements:

 - indicate this by emptying/resetting the field and adding a disabled attribute.
 - append a note which says "The contents of this field will be deleted" 

It would also be helpful to add a note saying that leaving fields empty will make no changes to any records.
Comment 1 Owen Leonard 2012-08-20 18:16:08 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-08-20 19:38:33 UTC
Created attachment 11712 [details] [review]
[SIGNED-OFF] Bug 7784 - Improve clarity of batch modification operations

- Improve clarity of hint about checkboxes
- Inicate that leaving fields blank will make no change
- Add a hint when checking checkboxes stating that the field will
  be deleted.
- Block deletion of required subfields
- Add "required" style to required subfields (matching additem.pl)

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Works as described
Comment 3 Jonathan Druart 2012-09-04 09:37:02 UTC
QA Comment:

Just one question: what is the utility of the last line of your patch:
+                <span class="hint" id="hint[% ite.tag %][% ite.subfield %][% ite.random %]"></span>

Else nothing to say, works as expected, no regression.

Marked as Passed QA
Comment 4 Paul Poulain 2012-09-05 13:26:14 UTC
Patch pushed to master
Comment 5 Owen Leonard 2012-11-21 17:47:47 UTC
(In reply to comment #3)

> Just one question: what is the utility of the last line of your patch:
> +                <span class="hint" id="hint[% ite.tag %][% ite.subfield
> %][% ite.random %]"></span>

The hint is shown if you check the box to delete a subfield: "This subfield will be deleted." The ID is attached so that if you uncheck the box the hint can be removed again.