Bug 7812 - Add markup to staff interface templates to increase customization options
Summary: Add markup to staff interface templates to increase customization options
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 10:35 UTC by Owen Leonard
Modified: 2023-01-08 00:25 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Screenshot showing #header_wrapper highlighted (58.92 KB, image/png)
2012-03-23 10:35 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-03-23 10:35:53 UTC
Created attachment 8570 [details]
Screenshot showing #header_wrapper highlighted

Following up on Bug 7760, there are markup changes we could add to further increase the options for CSS customizations. In the current markup:

<body id="circ_circulation-home" class="circ">
  <div id="header">...</div>
  <h1 id="logo">...</div>
  <div id="header_search">...</div>
  <div id="breadcrumbs">...</div>

I think it would be good to create a wrapper div for everything which is fall under the broad category of "header" (as opposed to "body" in the structural sense):

<body id="circ_circulation-home" class="circ">
  <div id="header_wrapper">
    <div id="header">...</div>
    <h1 id="logo">...</div>
    <div id="header_search">...</div>
    <div id="breadcrumbs">...</div>
  </div>

I would then add a new <div> which marks the "body" of the page, between #header_wrapper and the language footer. This would open just before the beginning of the main YUI grid declaration:

<div id="body">
<div id="doc" class="yui-t7">

...and close just before the footer include:

</div>
[% INCLUDE 'intranet-bottom.inc' %]

Unfortunately this means making edits to each template. But it introduces no visual changes to the templates unless custom CSS is added, so the work can happen piece by piece without any disruptions.
Comment 1 Katrin Fischer 2019-03-14 07:22:20 UTC
Hi Owen, is this still something we should work towards too?
Comment 2 Owen Leonard 2019-03-18 12:50:26 UTC
I can tell by the screenshot and the fact that I don't remember this bug that it was filed a while ago! It is still valid, and it's unfortunate I didn't take it into account while doing the Bootstrap grid upgrades :(