opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding because of this bug, it's possible for the system to appear unavailable after an update, when it is actually available a redirect from opac-maintance.pl would fix this problem :)
(In reply to comment #0) > opac-maintanance.pl should correctly redirect back to opac-main.pl, if no > updates are outstanding > > because of this bug, it's possible for the system to appear unavailable > after an update, when it is actually available > > a redirect from opac-maintance.pl would fix this problem :) oops, i speld 'maintenance' worng 3 times... :p
Created attachment 17112 [details] [review] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding
(In reply to comment #2) > Created attachment 17112 [details] [review] [review] > Bug 7853 - opac-maintanance.pl should correctly redirect back to > opac-main.pl, if no updates are outstanding to test, before patch is applied… 1/ edit your 'version' syspref and make your version just less that it currently is so from 3.1200202 to to 3.1200201, (your version number may be differnt to mine) 2/ load your OPAC url in a browser, you should be redirected to the 'OPAC maintenance' page (leave this window/tab open) 3/ change your version syspref back to the original number 4/ reload your 'OPAC maintenance' page, it should *not* return to OPAC page (fyi, this is the bug) 5/ apply patch 6/ repeat steps 1 thru 3 7/ reload your 'OPAC maintenance' page, it should now redirect to the OPAC page ( bug is now fixed)
Created attachment 17131 [details] [review] [SIGNED-OFF] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works exactly as it should according to the test plan. This is a nice improvement.
QA comment: A use case is not supported: I am going to make a maintenance operation on a server, I switch on the syspref OpacMaintenance. opac-main redirects on opac-maintenance and opac-maintenance redirects to opac-main :) Marked as Failed QA.
The fix is easy, I will provide a new patch.
Created attachment 17160 [details] [review] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works exactly as it should according to the test plan. This is a nice improvement. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Check OpacMaintenance!
Created attachment 17188 [details] [review] Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works exactly as it should according to the test plan. This is a nice improvement. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Check OpacMaintenance! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Not really anything to say. Nice patch. Now I just need to refresh and come back to opac as soon as maintenance finished. Just for the record and a formality: Jonathan, I would have preferred a followup adding the necessary OpacMaintenance test. (Have amended in the past too much too :) And if somebody likes to add a followup.. Why not say that kohaversion must be koha_db_version? In the very exceptional case that kohaversion=3.10 and db version= 3.12, something goes wrong. Wouldn't that be safe to go to maintenance as well? Passed QA
(In reply to comment #9) > And if somebody likes to add a followup.. Why not say that kohaversion must > be koha_db_version? In the very exceptional case that kohaversion=3.10 and > db version= 3.12, something goes wrong. Wouldn't that be safe to go to > maintenance as well? Added note: I changed this in the code when testing. It is a different thing coming there..
(In reply to comment #10) > (In reply to comment #9) > > And if somebody likes to add a followup.. Why not say that kohaversion must > > be koha_db_version? In the very exceptional case that kohaversion=3.10 and > > db version= 3.12, something goes wrong. Wouldn't that be safe to go to > > maintenance as well? > > Added note: I changed this in the code when testing. It is a different thing > coming there.. hmmm, a good question Marcel, but i think this is a bad idea... there are valid/legitimate situations both for production and dev/testing usage, where people may want to load a newer db onto an older Koha codebase. your proposed change would stop this from happening
(In reply to comment #5) > QA comment: > A use case is not supported: > I am going to make a maintenance operation on a server, I switch on the > syspref OpacMaintenance. opac-main redirects on opac-maintenance and > opac-maintenance redirects to opac-main :) > thanks for spotting this Jonathan, and the patch too :)
(In reply to comment #11) > there are valid/legitimate situations both for production and dev/testing > usage, where people may want to load a newer db onto an older Koha codebase. no problem. Hope that those people know what they are doing :)
This patch has been pushed to master and 3.12.x.