When creating a new notice (my example was All libraries - routing list) a lot of entries in the log are created: [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 175., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 178., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 181., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 192., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 200., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sat Mar 31 20:51:52 2012] [error] [client 127.0.0.1] [Sat Mar 31 20:51:52 2012] letter.pl: Problem = a value of 1 has been passed to param without key at /home/katrin/kohaclone/C4/Templates.pm line 187., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl
I don't believe this is still valid. Can you check?
These days they look a little different: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. CGI::param called in list context from /home/vagrant/kohaclone/svc/letters/get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412.
Created attachment 88996 [details] [review] Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT
Created attachment 89329 [details] [review] Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 89478 [details] [review] Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06