Bug 7883 - save and continue editing
Summary: save and continue editing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Elliott Davis
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 10182
  Show dependency treegraph
 
Reported: 2012-04-02 22:19 UTC by Melia Meggs
Modified: 2014-12-07 20:02 UTC (History)
8 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Rebase for master (23.22 KB, patch)
2012-11-20 14:54 UTC, Elliott Davis
Details | Diff | Splinter Review
Added the ability to save and continue editing in cataloging. (5.48 KB, patch)
2013-01-29 07:33 UTC, Elliott Davis
Details | Diff | Splinter Review
Added the ability to save and continue editing in cataloging. (5.51 KB, patch)
2013-02-18 16:09 UTC, Paul Poulain
Details | Diff | Splinter Review
Added the ability to save and continue editing in cataloging. (3.39 KB, patch)
2013-03-01 17:15 UTC, Elliott Davis
Details | Diff | Splinter Review
Bug 7883 - Save and continue editing for cataloging (3.53 KB, patch)
2013-03-13 22:59 UTC, Liz Rea
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7883 - Save and continue editing for cataloging (3.60 KB, patch)
2013-03-18 10:09 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 7883 - Save and continue editing for cataloging (3.74 KB, patch)
2013-05-03 09:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Melia Meggs 2012-04-02 22:19:54 UTC
Would like a 3rd option on the save button in cataloging.  Save and continue
editing.  Should not go out of the current screen a cataloger is looking at.
Comment 1 Elliott Davis 2012-11-20 14:54:52 UTC Comment hidden (obsolete)
Comment 2 Elliott Davis 2012-11-20 14:57:44 UTC
Comment on attachment 13554 [details] [review]
Rebase for master

Apologies, slip of the finger on the bug number
Comment 3 Elliott Davis 2013-01-29 07:33:26 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2013-02-18 16:09:15 UTC
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Comment 5 Paul Poulain 2013-02-18 16:09:35 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-02-19 09:26:43 UTC
QA Comment:

Changes in addbiblio.tt reference some nonexistent files:

+ [% IF ( CAN_user_editcatalogue_edit_items ) %]<form action="/cgi-bin/koha/cataloguing/additemelliott.pl" method="get">
+ </form>[% ELSE %]<form action="/cgi-bin/koha/catalogue/detailelliott.pl" method="get">
+ <form action="/cgi-bin/koha/cataloguing/addbibliolasers.pl" method="get">

Marked as Failed QA.
Comment 7 Elliott Davis 2013-03-01 17:15:54 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2013-03-13 20:07:41 UTC
This needs to be revised to work with the new Bootstrap toolbar.
Comment 9 Liz Rea 2013-03-13 22:59:16 UTC Comment hidden (obsolete)
Comment 10 Alex Arnaud 2013-03-18 10:09:27 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2013-05-03 09:48:53 UTC
QA comment:

Works as expected. This patch allows to do a save and to continue editing the same notice.

An improvement could be to stay on the same tab after saving.
I will open a new report for that.

Marked as Passed QA.
Comment 12 Jonathan Druart 2013-05-03 09:49:15 UTC
Created attachment 17921 [details] [review]
Bug 7883 - Save and continue editing for cataloging

Patch reworked from Elliot Davis' original patch - but using bootstrap instead of YUI.

This patch adds the ability for catalogers to save and continue editing when adding new biblios.

To Test:

Select an existing item or create a new item in cataloging using your favorite framework.
Edit the bib
From the save menu in the dropdown, select the new option of "Save and continue editing"
If you are missing required fields you should still be prompted to fill them in before saving
Once all required fields are in place you should be allowed to save, and you will be redirected to tab 0.

The original patch claims to redirect to the original tab, but I never observed that behaviour from it - this patch merely takes what was in the original and makes it boostrap.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 13 Galen Charlton 2013-05-21 18:09:14 UTC
Pushed to master.  Thanks, Elliott!