debian/templates/apache-site.conf.in creates a per-site Apache conf file that contains this: # TransferLog /var/log/koha/__KOHASITE__/opac-access_log If this line is simply uncommented (by naive people like me), it will result in an access log like this: /var/log/koha/mysite/opac-access_log Now, the packages set up logrotate, but it only looks for this pattern: /var/log/koha/*/*.log which results in the TransferLog not getting picked up by logrotate. Is there a specific reason for doing it this way, or would it be better if we changed the Apache conf file to this: # TransferLog /var/log/koha/__KOHASITE__/opac-access.log --- Apache conf template: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/templates/apache-site.conf.in logrotate config: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/koha-common.logrotate
It's a weird apache default thing. I usually end up changing it manually whenever I enable the transfer log. So yes, I very much think it should be .log too.
Created attachment 8856 [details] [review] Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour.
Created attachment 8860 [details] [review] Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour. Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Verified that it's totally harmless and ultimately a good thing to do.
Very simple change, _ to . in several cases. If the Package Manager verifies it's safe, I'm inclined to believe. Passed QA.
in fact, I even think it's not an enhancement, but a bugfix, so updating severity
This patch will be included in 3.6.5.