When displaying in-page errors or messages to the user a standard style should be used. Errors, alerts, or other messages which indicate failures, warnings, or other high-priority information should use: <div class="dialog alert"> ...error... </div> Informational messages should use: <div class="dialog message"> ...message... </div>
Created attachment 9629 [details] [review] Bug 7889 [Subscription renew] Use standard style for errors and messages Styling subscription renew message according to standard style. Also: - Adding direct link to renew from message suggesting renew. - Adding output of expiration date to message. To test open a subscription with an impending expiration. You should see a dialog-styled message, "Subscription will expire XX/XX/XXXX. Renew this subscription."
Created attachment 9630 [details] [review] Bug 7889 [Authorities duplicates] Use standard style for errors and messages The warning shown in the authorities editor when there is a possible duplicate is styled incorrectly. In addition the design of the warning is inconsistent with that shown in the bibliographic record editor. This patch revises the style and layout of the duplicate error box. It also corrects a problem which appears in the biblio and authority editors where a non-existent JS window function was called. I have added the function to the default JS include and revised the editor pages to use it. To test: - Create a record in both the cataloging and authorities editors which will trigger a duplicate warning. - Click the link to the existing record. A separate window should pop up. - In both editors try each option: - Confirm the duplicate and go to the existing record. - Deny that the record is duplicate and continue to save.
Created attachment 9631 [details] [review] Bug 7889 [Search errors] Use standard style for errors and messages There are two instances in the templates where markup is defined for displaying search errors. I've never seen these appear and I have no idea what kind of error might trigger it, but now it will display correctly.
Created attachment 9632 [details] [review] Bug 7889 [Acquisitions] Use standard style for errors and messages Correcting style of the warning on the Acquisitions home page which appears if no budgets have been defined. Also correcting the logic by which the warning appears, as a change to the script inadvertently prevented it.
Created attachment 9658 [details] [review] Bug 7889 - Use standard style for errors and messages Styling subscription renew message according to standard style. Also: - Adding direct link to renew from message suggesting renew. - Adding output of expiration date to message. To test open a subscription with an impending expiration. You should see a dialog-styled message, "Subscription will expire XX/XX/XXXX. Renew this subscription." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 9659 [details] [review] Bug 7889 [Authorities duplicates] Use standard style for errors and messages The warning shown in the authorities editor when there is a possible duplicate is styled incorrectly. In addition the design of the warning is inconsistent with that shown in the bibliographic record editor. This patch revises the style and layout of the duplicate error box. It also corrects a problem which appears in the biblio and authority editors where a non-existent JS window function was called. I have added the function to the default JS include and revised the editor pages to use it. To test: - Create a record in both the cataloging and authorities editors which will trigger a duplicate warning. - Click the link to the existing record. A separate window should pop up. - In both editors try each option: - Confirm the duplicate and go to the existing record. - Deny that the record is duplicate and continue to save. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 9660 [details] [review] Bug 7889 [Search errors] Use standard style for errors and messages There are two instances in the templates where markup is defined for displaying search errors. I've never seen these appear and I have no idea what kind of error might trigger it, but now it will display correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 9661 [details] [review] Bug 7889 [Acquisitions] Use standard style for errors and messages Correcting style of the warning on the Acquisitions home page which appears if no budgets have been defined. Also correcting the logic by which the warning appears, as a change to the script inadvertently prevented it. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA Comments: All patches passed QA. Just one span class "problem" already exists, in serials/serials-collection.tt
could be backported to 3.8, but it's just a display fix, so maybe not worth the risk for a side effect
Created attachment 11085 [details] [review] Bug 7889 - Use standard style for errors and messages Correcting the markup of error messages in three places: catalogue merge, CSV profile editing, and opac comments.
Created attachment 11105 [details] [review] Bug 7889 - Use standard style for errors and messages Correcting the markup of error messages in three places: catalogue merge, CSV profile editing, and opac comments. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Only last patch not applied already. passed QA
Released in 3.10.0