When you're cataloging if you forget to fill in some fields an error pops up and then the fields you forgot to fill in are highlighted in yellow - why not highlight them in yellow to start with so that they stand out better?
Created attachment 86112 [details] [review] Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required."
I got this error below when I tried to import a record ("Sometimes I lie" by Alice Feeney) Steps: 1. Go to Cataloging 2. Click "New from Z39.5/SRU" button 3. Put "Sometimes I lie" in the title field and hit "Search" 4. Click on a row and select "Import" Error: Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 876. Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 877. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 889. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 890. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 941. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 945. syntax error at /kohadevbox/koha/cataloguing/addbiblio.pl line 961, near ") {" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/cataloguing/addbiblio.pl line 978. at /usr/share/perl5/CGI/Compile.pm line 132
(In reply to Cori Lynn Arnold from comment #2) > I got this error below when I tried to import a record ... > Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol > "$tab" requires explicit package name (did you forget to declare "my $tab"?) My patch only changes the template, so I think this error has another cause. Did you apply all the dependencies first? Maybe you need to use the "restart_all" command?
Created attachment 86544 [details] [review] Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required."
Does this one need a rebase because of the reversion of 22399?
Created attachment 89734 [details] [review] Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required."
Created attachment 89918 [details] [review] Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 90032 [details] [review] Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01